From: Yuan Fu <casouri@gmail.com>
To: Juri Linkov <juri@linkov.net>
Cc: 71681@debbugs.gnu.org
Subject: bug#71681: 29.3.50; tree-sitter crash
Date: Mon, 1 Jul 2024 00:01:23 -0700 [thread overview]
Message-ID: <C5CEE51F-EDFA-4CF2-9D22-3E1242EEC0B8@gmail.com> (raw)
In-Reply-To: <864j99d2vr.fsf@mail.linkov.net>
> On Jun 30, 2024, at 11:49 PM, Juri Linkov <juri@linkov.net> wrote:
>
>> I reduced the crash to a signal and pushed the fix to emacs-30.
>> Next I’ll make sure the signal is properly handled.
>
> Now with the latest emacs-30 at the commit b2c966f8396
> there is another problem:
>
> 0. emacs -Q
> 1. eval: (setq backtrace-on-redisplay-error t)
> 2. eval: (add-to-list 'major-mode-remap-alist '(c-mode . c-ts-mode))
> 3. C-x v L
> 4. in the *vc-change-log* buffer move point to the commit b2c966f8396
> 5. type D
>
> Warning (error): Error in a redisplay Lisp hook.
> See buffer *Redisplay-trace*
>
> Error: treesit-node-outdated (#<treesit-node-outdated>)
> treesit--font-lock-fontify-region-1(#<treesit-node-outdated> #<treesit-compiled-query> 99654 99975 nil nil)
> treesit-font-lock-fontify-region(99654 99975 nil)
> font-lock-fontify-syntactically-region(99654 99975 nil)
> font-lock-default-fontify-region(99654 99974 nil)
> font-lock-fontify-region(99654 99974)
> font-lock-ensure(99654 99974)
> diff-syntax-fontify-hunk(122 539 t)
> diff-syntax-fontify(122 539)
> diff--font-lock-syntax(539)
> font-lock-fontify-keywords-region(1 539 nil)
> font-lock-default-fontify-region(1 539 nil)
> font-lock-fontify-region(1 539)
> jit-lock--run-functions(1 539)
> jit-lock-fontify-now(1 539)
> jit-lock-function(1)
> vc-diff-finish(#<buffer *vc-diff*> nil nil)
> vc-exec-after(#f(compiled-function () #<bytecode -0xcd6e6e57937525e>))
> log-view-diff-common(1 1 t)
> log-view-diff-changeset(1 1)
> funcall-interactively(log-view-diff-changeset 1 1)
> command-execute(log-view-diff-changeset)
Yes, that’s what meant by “reduced crash to signal”. The crash is fixed, but I need to fix the font-lock code so it can handle the signal gracefully (or don’t cause the signal from the first place). It’s not yet clear to me why does treesit-font-lock-fontify-region end up using an outdated node for query.
Yuan
prev parent reply other threads:[~2024-07-01 7:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 16:33 bug#71681: 29.3.50; tree-sitter crash Juri Linkov
2024-06-22 23:55 ` Yuan Fu
2024-06-23 5:32 ` Eli Zaretskii
2024-06-23 6:46 ` Juri Linkov
2024-06-23 17:38 ` Juri Linkov
2024-06-24 7:46 ` Yuan Fu
2024-06-26 6:04 ` Yuan Fu
2024-06-29 23:54 ` Yuan Fu
2024-06-30 14:28 ` Vincenzo Pupillo
2024-06-30 16:15 ` Juri Linkov
2024-06-30 19:22 ` Vincenzo Pupillo
2024-07-01 5:37 ` Yuan Fu
2024-07-01 10:20 ` Vincenzo Pupillo
2024-07-01 6:49 ` Juri Linkov
2024-07-01 7:01 ` Yuan Fu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C5CEE51F-EDFA-4CF2-9D22-3E1242EEC0B8@gmail.com \
--to=casouri@gmail.com \
--cc=71681@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.