From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jan =?UTF-8?Q?Dj=C3=A4rv?= Newsgroups: gmane.emacs.bugs Subject: bug#16683: 24.3; Crash on OS X when loading a bad PPM image Date: Wed, 12 Feb 2014 08:53:46 +0100 Message-ID: References: <1864A71D-D864-46CA-9219-73616E12652D@ravenbrook.com> <20140209223000.GA32384@hirohito.acc.umu.se> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1392191653 12105 80.91.229.3 (12 Feb 2014 07:54:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 12 Feb 2014 07:54:13 +0000 (UTC) Cc: 16683@debbugs.gnu.org, Gareth Rees To: Marcus Karlsson Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 12 08:54:20 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WDUeB-000692-9n for geb-bug-gnu-emacs@m.gmane.org; Wed, 12 Feb 2014 08:54:19 +0100 Original-Received: from localhost ([::1]:37830 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDUeA-0005ex-KF for geb-bug-gnu-emacs@m.gmane.org; Wed, 12 Feb 2014 02:54:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36032) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDUe2-0005eo-Be for bug-gnu-emacs@gnu.org; Wed, 12 Feb 2014 02:54:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WDUdw-0008R1-Ga for bug-gnu-emacs@gnu.org; Wed, 12 Feb 2014 02:54:10 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47026) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDUdw-0008Qx-D6 for bug-gnu-emacs@gnu.org; Wed, 12 Feb 2014 02:54:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WDUdv-0005Ia-B5 for bug-gnu-emacs@gnu.org; Wed, 12 Feb 2014 02:54:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jan =?UTF-8?Q?Dj=C3=A4rv?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Feb 2014 07:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16683 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16683-submit@debbugs.gnu.org id=B16683.139219163920359 (code B ref 16683); Wed, 12 Feb 2014 07:54:02 +0000 Original-Received: (at 16683) by debbugs.gnu.org; 12 Feb 2014 07:53:59 +0000 Original-Received: from localhost ([127.0.0.1]:48208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WDUdq-0005IG-Tt for submit@debbugs.gnu.org; Wed, 12 Feb 2014 02:53:59 -0500 Original-Received: from mailfe01.swip.net ([212.247.154.1]:41992 helo=swip.net) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WDUdl-0005Hv-Bf for 16683@debbugs.gnu.org; Wed, 12 Feb 2014 02:53:54 -0500 X-T2-Spam-Status: No, hits=0.0 required=5.0 Original-Received: from hosdjarv.se (account mj138573@tele2.se [46.59.42.57] verified) by mailfe01.swip.net (CommuniGate Pro SMTP 5.4.4) with ESMTPA id 479403190; Wed, 12 Feb 2014 08:53:46 +0100 In-Reply-To: <20140209223000.GA32384@hirohito.acc.umu.se> X-Mailer: Apple Mail (2.1827) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:85424 Archived-At: Hello. 9 feb 2014 kl. 23:30 skrev Marcus Karlsson : > On Fri, Feb 07, 2014 at 01:53:14PM +0000, Gareth Rees wrote: >> Emacs for Mac OS X crashes when trying to display a badly formatted >> PPM image. The crash is 100% reproducible. >=20 > I'm able to reproduce this crash on the current head. >=20 > My impression after running it through the debugger is that -release = is > called on the pixmap after it has been deallocated earlier in = pbm_load. > I have created a patch that sets the pixmap to NO_PIXMAP in case > pbm_load runs into an error. >=20 Applied thanks. > In the long run the better solution is probably to look over the NS > memory management so that it works properly. This happens in the generic code, it should not try to free garbage, so = this fix is OK. An alternative would be to check load_failed in free_image. Still = generic code. Jan D.