From: "Jan Djärv" <jan.h.d@swipnet.se>
To: Marcus Karlsson <mk@acc.umu.se>
Cc: 16683@debbugs.gnu.org, Gareth Rees <gdr@ravenbrook.com>
Subject: bug#16683: 24.3; Crash on OS X when loading a bad PPM image
Date: Wed, 12 Feb 2014 08:53:46 +0100 [thread overview]
Message-ID: <C5AC1A97-E1F6-4F5D-9AFE-FB02896C818C@swipnet.se> (raw)
In-Reply-To: <20140209223000.GA32384@hirohito.acc.umu.se>
Hello.
9 feb 2014 kl. 23:30 skrev Marcus Karlsson <mk@acc.umu.se>:
> On Fri, Feb 07, 2014 at 01:53:14PM +0000, Gareth Rees wrote:
>> Emacs for Mac OS X crashes when trying to display a badly formatted
>> PPM image. The crash is 100% reproducible.
>
> I'm able to reproduce this crash on the current head.
>
> My impression after running it through the debugger is that -release is
> called on the pixmap after it has been deallocated earlier in pbm_load.
> I have created a patch that sets the pixmap to NO_PIXMAP in case
> pbm_load runs into an error.
>
Applied thanks.
> In the long run the better solution is probably to look over the NS
> memory management so that it works properly.
This happens in the generic code, it should not try to free garbage, so this fix is OK.
An alternative would be to check load_failed in free_image. Still generic code.
Jan D.
prev parent reply other threads:[~2014-02-12 7:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 13:53 bug#16683: 24.3; Crash on OS X when loading a bad PPM image Gareth Rees
2014-02-09 22:30 ` Marcus Karlsson
2014-02-12 7:53 ` Jan Djärv [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C5AC1A97-E1F6-4F5D-9AFE-FB02896C818C@swipnet.se \
--to=jan.h.d@swipnet.se \
--cc=16683@debbugs.gnu.org \
--cc=gdr@ravenbrook.com \
--cc=mk@acc.umu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.