all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: xah lee <xah@xahlee.org>
To: Jason Rumney <jasonr@gnu.org>
Cc: emacs-pretest-bug@gnu.org,
	YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
Subject: Re: unable to open jpg file
Date: Mon, 14 Jan 2008 05:42:36 -0800	[thread overview]
Message-ID: <C5871F6F-4A8F-4FAA-8B00-967E36AA6D44@xahlee.org> (raw)
In-Reply-To: <478B618B.6040404@gnu.org>

I followed your instruction and that fixed the problem for my  
original images.

Thanks.

   Xah
   xah@xahlee.org
∑ http://xahlee.org/


On Jan 14, 2008, at 5:20 AM, Jason Rumney wrote:

YAMAMOTO Mitsuharu wrote:
> As image-jpeg-p returns nil for that image data (no "JFIF" or "Exif"
> as a substring), it couldn't be displayed even with the X11 version,
> either.  As this is not Carbon-specific, I would like to leave the
> issue to those who are more familiar with image.el and/or image format
> spec.
>

I found some more work friendly non-JFIF/Exif JPEG images here:

http://www.marysvilletourism.com/media/index.htm

Firefox and Emacs 22 fail to display these images, but Emacs trunk  
displays them (is this the case with the images in the original  
report?).

The difference between Emacs 22 and trunk seems to be in the function  
image-type. In Emacs 22, if the image headers do not determine the  
type, we convert the file extension to a symbol and use that. This  
means .jpg files are given a type of 'jpg, which is not the correct  
image-type for jpeg images.

The trunk has been changed to use image-type-from-file-name instead,  
which correctly returns 'jpeg for that image.

I have backported that change to emacs-22.


☄

  reply	other threads:[~2008-01-14 13:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-13  2:58 unable to open jpg file xah lee
2008-01-14  2:01 ` Richard Stallman
2008-01-14  3:29 ` YAMAMOTO Mitsuharu
2008-01-14  3:55   ` xah lee
2008-01-14  4:27     ` YAMAMOTO Mitsuharu
2008-01-14 13:20       ` Jason Rumney
2008-01-14 13:42         ` xah lee [this message]
2008-01-14 22:36         ` James Cloos
2008-01-15 16:08           ` Tom Tromey
2008-01-14 17:26       ` Richard Stallman
2008-01-14 23:15         ` Jason Rumney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C5871F6F-4A8F-4FAA-8B00-967E36AA6D44@xahlee.org \
    --to=xah@xahlee.org \
    --cc=emacs-pretest-bug@gnu.org \
    --cc=jasonr@gnu.org \
    --cc=mituharu@math.s.chiba-u.ac.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.