From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#67116: byte-compile-let: reversing the order of evaluation of the clauses CAN make a difference Date: Mon, 13 Nov 2023 12:19:27 +0100 Message-ID: References: <2324648E-F860-4D57-A7A9-CF0F4F9DB57E@gmail.com> <90BD98E4-1026-4290-9D9F-7A413E670DCC@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17549"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67116-done@debbugs.gnu.org, Stefan Monnier To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 13 12:20:47 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r2Uzm-0004KE-NA for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Nov 2023 12:20:46 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r2UzO-0000S6-Bm; Mon, 13 Nov 2023 06:20:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2UzM-0000Rk-UZ for bug-gnu-emacs@gnu.org; Mon, 13 Nov 2023 06:20:21 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r2UzM-0003Ma-MF for bug-gnu-emacs@gnu.org; Mon, 13 Nov 2023 06:20:20 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r2V01-0006xU-U7 for bug-gnu-emacs@gnu.org; Mon, 13 Nov 2023 06:21:01 -0500 Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Nov 2023 11:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 67116 X-GNU-PR-Package: emacs Mail-Followup-To: 67116@debbugs.gnu.org, mattias.engdegard@gmail.com, acm@muc.de Original-Received: via spool by 67116-done@debbugs.gnu.org id=D67116.169987442026679 (code D ref 67116); Mon, 13 Nov 2023 11:21:01 +0000 Original-Received: (at 67116-done) by debbugs.gnu.org; 13 Nov 2023 11:20:20 +0000 Original-Received: from localhost ([127.0.0.1]:57572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2UzL-0006wF-Nu for submit@debbugs.gnu.org; Mon, 13 Nov 2023 06:20:19 -0500 Original-Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]:49543) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2UzJ-0006w2-HG for 67116-done@debbugs.gnu.org; Mon, 13 Nov 2023 06:20:18 -0500 Original-Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-507973f3b65so6115385e87.3 for <67116-done@debbugs.gnu.org>; Mon, 13 Nov 2023 03:19:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699874370; x=1700479170; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=pcLSo99MnCtAeA1wdQ/KXsqWugQ6mw6NXOozFKccVek=; b=lL9H4+BnykZxaq6UutkeKr2fisLJPfZ3SYR6YFgN6aykmPPkijtkfPTFdg2kWfkQnE TVB2XkW76QPLVez1KZOkb54x6DpoICYjhn1IUpR5bA0tNVitYdB1ttXjRKlKDs6ovg0N 1tpJHWGfemB0sU8awhbnhqkTjpcIpMJCLbI66Ks2k+ONdLoTsK6EHINFqZ06WLrq8HS3 yBvjABXduoNnyeGivBGv3iOFp8fbobkjgWwE2ivEvCHdWBON4jQXXrhTt+05fCzvISoP QHtD6ZUQIejKrtklMgmXvzHYQsiyTM66YjEXRZaoC9O4ke0DtQf7ubKdkzWrdBbvXj4C uFfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699874370; x=1700479170; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=pcLSo99MnCtAeA1wdQ/KXsqWugQ6mw6NXOozFKccVek=; b=BjpUCmfGKs7WMyN95S13yQc7+Ee974Mgs8+YI1BZow6AUKKy4VbqqJmx10dG64AtJH azNTCSrIK1F2glImxWk4h2vte2zzjqzi/6xVGFN6t/jFwlxXZOpsdeKBAEZXx70kRmgx aN1NUTqeMuDf8WMU6L5mk4TEZg/8B9+7u9qsuAsbScrh+pb13vxwt/Y5/5hMmZkc64IT SuC3EjvxngVRVT0pxgrXYXcC2DPq0L2YbPNZ0eCuPKR89zsP8nfKdUgcMI8q23oV0wVw rrRnHeNLxXgmHEFCDYCiGxuoUX0rwkJ83WG9FMPSX+SEx3GXA8U0qa10ACyHqsReyemN t5uw== X-Gm-Message-State: AOJu0YwDS9+EuPqcz9y2xpt1KC+vI3wvzAnXJ5/lw0T3myKK7VD0cstd 37IUyqZK0Jmdf7UsJ+jCKEU= X-Google-Smtp-Source: AGHT+IHJ8cnQZnMg36FY6RJlAZtFbCZVorUlP+L//y3aUDNOnT1IARTvZXkHcfcC4bPp83CT1ZTsHA== X-Received: by 2002:ac2:434d:0:b0:508:26b2:7803 with SMTP id o13-20020ac2434d000000b0050826b27803mr3876832lfl.69.1699874369568; Mon, 13 Nov 2023 03:19:29 -0800 (PST) Original-Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id be20-20020a056512251400b00507f0d2b32bsm942500lfb.249.2023.11.13.03.19.28 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Nov 2023 03:19:28 -0800 (PST) In-Reply-To: <90BD98E4-1026-4290-9D9F-7A413E670DCC@gmail.com> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274250 Archived-At: > There's a bug here, will fix. Now fixed on master. I'm very pleased that you reported this bug. (Of course it didn't have anything to do with order of evaluation at all = but you already understood that.) I didn't do a deep analysis of what code was affected by the bug but = measuring changes in the bytecode size, which is usually quite good, = only two places turned up: jit-lock--debug-fontify, which you already = noticed, and c-forward-sws in cc-engine.el, where the code (c-put-in-sws rung-pos (setq rung-pos (point) last-put-in-sws-pos rung-pos))) was probably affected here. (Obviously the bug was out to get you = personally, Alan.)