From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE Date: Sun, 5 Apr 2020 15:40:36 +0200 Message-ID: References: <805F9723-8298-4FD7-A47B-1E683721A5B0@acm.org> <835zegwn9y.fsf@gnu.org> <83mu7rvbyk.fsf@gnu.org> <729DE2D1-EA0F-46F9-8B4B-2ED146CE6892@acm.org> <83pncntbc2.fsf@gnu.org> <038251F3-AAA0-4528-ADB3-6E29F5A51B82@acm.org> <835zeet636.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.14\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="93462"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 40407@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 05 15:41:15 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jL5WU-000OEr-Qr for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Apr 2020 15:41:14 +0200 Original-Received: from localhost ([::1]:48074 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jL5WT-0005WM-TU for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Apr 2020 09:41:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56849) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jL5WJ-0005QA-0U for bug-gnu-emacs@gnu.org; Sun, 05 Apr 2020 09:41:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jL5WI-0003HO-13 for bug-gnu-emacs@gnu.org; Sun, 05 Apr 2020 09:41:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33832) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jL5WH-0003HC-U6 for bug-gnu-emacs@gnu.org; Sun, 05 Apr 2020 09:41:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jL5WH-0004yI-LJ for bug-gnu-emacs@gnu.org; Sun, 05 Apr 2020 09:41:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Apr 2020 13:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40407 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 40407-submit@debbugs.gnu.org id=B40407.158609404919064 (code B ref 40407); Sun, 05 Apr 2020 13:41:01 +0000 Original-Received: (at 40407) by debbugs.gnu.org; 5 Apr 2020 13:40:49 +0000 Original-Received: from localhost ([127.0.0.1]:45378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jL5W5-0004xP-7o for submit@debbugs.gnu.org; Sun, 05 Apr 2020 09:40:49 -0400 Original-Received: from mail1445c50.megamailservers.eu ([91.136.14.45]:42560 helo=mail265c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jL5W2-0004wu-8Y for 40407@debbugs.gnu.org; Sun, 05 Apr 2020 09:40:47 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1586094039; bh=QnIKWgMVVdg8NwFpcmenIHMU0H+/XHB0iKaq1gSnFJI=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=O4LlSVHGbmKTPz0LymQvB0+GH/4iTZg0C4kGhvJZk+3ZDlEq/qHcPGMJfpHC2jWzB LaDJ+ina2sh3hWbd37Zt3ipYrRQgcsUrZYwx0EWuTk6HaDyvpbbF7FSZMTWvFjTXjO HP90qKyFhnsZCEgpCHxzSfgY5u7sqXiuo+T0JwwM= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail265c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 035Debj2022691; Sun, 5 Apr 2020 13:40:38 +0000 In-Reply-To: <835zeet636.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.104.14) X-CTCH-RefID: str=0001.0A782F1A.5E89DFB2.005E, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=D5w51cZj c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=J67hpjz6vsPl-x7vM6sA:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:178058 Archived-At: 5 apr. 2020 kl. 15.28 skrev Eli Zaretskii : > That is true, of course, but many/most of our strings are multibyte > nowadays, even if they are ASCII. Suddenly getting a unibyte string > instead would be surprising, I think, even if no one should depend on > it not happening. (NOCOPY case is different: then it's the caller's > responsibility to deal with the issue.) So I'd rather we produced a > multibyte string when "decoding" by copying. I don't agree fully but it is definitely not a strongly held opinion, so = I followed your suggestion. > One subtle point regarding this comment: I'd remove the "unibyte" > part Right, done. Thanks for the reviews!