all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: "'Leo'" <sdl.web@gmail.com>, <emacs-devel@gnu.org>
Subject: RE: widen-one-level    [was: Emacs's handling of line numbers]
Date: Mon, 19 Apr 2010 09:31:19 -0700	[thread overview]
Message-ID: <C444957FF7134F1BAC3242898727FD02@us.oracle.com> (raw)
In-Reply-To: <A8BF6B7A85EA4431908E7F12FD56C08D@us.oracle.com>

> > > (defadvice narrow-to-region
> > >   (before push-restriction-stack activate)
> > >   (setq restriction-stack  (cons (cons start end) 
> > >                                  restriction-stack))
> > >   (when (and (= start 1) (= end (1+ (buffer-size))))
> > >     (setq restriction-stack  ())))
> > 
> > I also have something similar in my .emacs. I wonder if you 
> > noticed this problem. After advising narrow-to-region,
> > preloaded functions such as narrow-to-page narrow-to-defun
> > still use the original narrow-to-region ignoring the advice.
> 
> Yes, I noticed that too. Presumably it's because 
> `narrow-to-region' has its own byte code. At least that's my
> guess. `narrow-to-defun' is a lisp function, and it is
> byte-compiled, which presumably means the byte-code for 
> `narrow-to-region' is inlined.
> 
> Or something like that. Someone more knowledgable will no 
> doubt enlighten us.

One (ugly) solution is to copy the Lisp source code for `narrow-to-defun' and
`narrow-to-page' to the same library that advises `narrow-to-region'. That way,
the advised definition is used also for the other two.





  parent reply	other threads:[~2010-04-19 16:31 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-15 18:47 Emacs's handling of line numbers [from bug#5042] Mark Lillibridge
     [not found] ` <jwvd4068dsr.fsf-monnier+emacs@gnu.org>
2010-04-11 22:22   ` Mark Lillibridge
2010-04-12  2:27     ` Stefan Monnier
2010-04-17  1:57       ` Mark Lillibridge
2010-04-17  7:29         ` Eli Zaretskii
2010-04-17 14:45           ` Stefan Monnier
2010-04-17 15:57             ` Eli Zaretskii
2010-04-17 19:51               ` Mark Lillibridge
2010-04-17 21:04                 ` Eli Zaretskii
2010-04-17 21:17                   ` Juanma Barranquero
2010-04-17 21:31                     ` Drew Adams
2010-04-18 18:15                       ` widen-one-level [was: Emacs's handling of line numbers] Drew Adams
2010-04-18 21:31                         ` Juri Linkov
2010-04-19  0:25                           ` Drew Adams
2010-04-18 23:30                         ` Davis Herring
2010-04-19 19:57                           ` Richard Stallman
2010-04-19 20:22                             ` Drew Adams
2010-04-19 22:52                             ` Juri Linkov
2010-04-19  1:56                         ` Leo
2010-04-19  2:04                           ` Drew Adams
2010-04-19 11:34                             ` Leo
2010-04-19 16:31                             ` Drew Adams [this message]
2010-04-19 17:57                               ` Leo
2010-04-19 22:56                                 ` Drew Adams
2010-04-22  9:59                                   ` Leo
2010-04-18  3:12                     ` Emacs's handling of line numbers [from bug#5042] Eli Zaretskii
2010-04-18  3:49                       ` Juanma Barranquero
2010-04-18  8:05                         ` Juri Linkov
2010-04-18 13:44                           ` Drew Adams
2010-04-18 13:50                             ` Lennart Borgman
2010-04-18 16:40                               ` Drew Adams
2010-04-18 14:03                             ` Juanma Barranquero
2010-04-18 14:14                               ` David Kastrup
2010-04-18 16:41                               ` Drew Adams
2010-04-18 17:03                                 ` Juanma Barranquero
2010-04-18 21:29                                   ` Juri Linkov
2010-04-18 13:45                           ` Drew Adams
2010-04-18 17:29                         ` Eli Zaretskii
2010-04-18 17:52                           ` Juanma Barranquero
2010-04-18 17:56                             ` Eli Zaretskii
2010-04-18 17:00                       ` Mark Lillibridge
2010-04-18 17:38                         ` Eli Zaretskii
2010-04-18 18:11                           ` Lennart Borgman
2010-04-22  2:17                           ` Mark Lillibridge
2010-04-22  8:06                             ` David Kastrup
2010-04-22  8:38                               ` Juri Linkov
2010-04-22  8:45                               ` Juanma Barranquero
2010-06-06 18:18                             ` Mark Lillibridge
2010-06-07  1:30                               ` Stefan Monnier
2010-06-07  1:41                                 ` Lennart Borgman
2010-06-07 13:45                                   ` Stefan Monnier
2010-06-09  2:20                                     ` Mark Lillibridge
2010-06-09  3:44                                       ` Miles Bader
2010-06-09  2:19                                 ` Mark Lillibridge
2010-06-09  6:37                                   ` Glenn Morris
2010-06-24  2:24                                     ` Mark Lillibridge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C444957FF7134F1BAC3242898727FD02@us.oracle.com \
    --to=drew.adams@oracle.com \
    --cc=emacs-devel@gnu.org \
    --cc=sdl.web@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.