From: "Drew Adams" <drew.adams@oracle.com>
To: "'Juri Linkov'" <juri@jurta.org>
Cc: 4033@emacsbugs.donarmstrong.com
Subject: bug#4033: 23.1; list-colors-display is misleading
Date: Tue, 4 Aug 2009 19:36:06 -0700 [thread overview]
Message-ID: <C35EC3D32A554E70A2598091126AE0CA@us.oracle.com> (raw)
In-Reply-To:
> What about something like this:
>
> (defun rgb-color-format-for-display ()
> (let ((ncolors (display-color-cells (selected-frame)))
> (exp 0))
> (while (> (lsh ncolors (- exp)) 1) (setq exp (1+ exp)))
> (setq exp (/ exp 12))
> (format "#%%0%dx%%0%dx%%0%dx" exp exp exp)))
>
> For 16777216 colors, that gives #%02x%02x%02x, which seems right.
>
> In `list-colors-print', we would then do this:
>
> (insert (apply 'format (rgb-color-format-for-display)
> (mapcar (lambda (c) (lsh c -8))
> (color-values (car color)))))
>
> IOW, replace the hard-coded "#%02x%02x%02x" with
> (rgb-color-format-for-display).
We would also want to first do that for one of the colors, to get the field
width, then use that here:
(indent-to (max (- (window-width) RGB-WIDTH) 44))
instead of hard-coding a width of 8, as now:
(indent-to (max (- (window-width) 8) 44))
prev parent reply other threads:[~2009-08-05 2:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-04 16:01 bug#4033: 23.1; list-colors-display is misleading Drew Adams
2009-08-04 18:04 ` Eli Zaretskii
2009-08-04 18:48 ` Drew Adams
2009-08-04 19:40 ` Drew Adams
2009-08-04 19:45 ` Eli Zaretskii
2009-08-04 19:58 ` Drew Adams
2009-08-04 22:59 ` Jason Rumney
2009-08-04 23:29 ` Drew Adams
2009-08-04 23:42 ` Jason Rumney
2009-08-04 23:55 ` Drew Adams
2009-08-05 3:22 ` Eli Zaretskii
2009-08-05 5:34 ` Drew Adams
2009-08-05 6:57 ` Jason Rumney
2009-08-05 17:34 ` Eli Zaretskii
2009-08-04 23:27 ` Andreas Schwab
2009-08-04 21:35 ` Juri Linkov
2009-08-04 23:29 ` Drew Adams
2009-08-05 2:25 ` Drew Adams
2009-08-05 2:58 ` Drew Adams
2009-08-05 21:35 ` Juri Linkov
2009-08-05 23:16 ` Drew Adams
2009-08-05 2:36 ` Drew Adams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C35EC3D32A554E70A2598091126AE0CA@us.oracle.com \
--to=drew.adams@oracle.com \
--cc=4033@emacsbugs.donarmstrong.com \
--cc=juri@jurta.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.