From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: "Victor J. Orlikowski" Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Prevent ERC from sending spurious PART messages Date: Thu, 30 Mar 2017 18:18:46 -0400 Message-ID: References: <6E627702-A0E8-47A6-8794-D90050E2CC13.notmuch@alumni.duke.edu> <87tw6axw1e.fsf@linux-m68k.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 (1.0) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1490913091 27873 195.159.176.226 (30 Mar 2017 22:31:31 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 30 Mar 2017 22:31:31 +0000 (UTC) Cc: emacs-devel@gnu.org To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 31 00:31:25 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ctib6-0005Wb-0B for ged-emacs-devel@m.gmane.org; Fri, 31 Mar 2017 00:31:16 +0200 Original-Received: from localhost ([::1]:37938 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ctibA-0005tf-GQ for ged-emacs-devel@m.gmane.org; Thu, 30 Mar 2017 18:31:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53304) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ctiP9-00041m-TL for emacs-devel@gnu.org; Thu, 30 Mar 2017 18:18:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ctiP6-0003N2-QG for emacs-devel@gnu.org; Thu, 30 Mar 2017 18:18:55 -0400 Original-Received: from mailout.easymail.ca ([64.68.201.169]:55966) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ctiP6-0003Lk-MQ for emacs-devel@gnu.org; Thu, 30 Mar 2017 18:18:52 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 7C4C2E15F; Thu, 30 Mar 2017 18:18:51 -0400 (EDT) Original-Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (easymail-mailout.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LNa5sLQLgzdL; Thu, 30 Mar 2017 18:18:50 -0400 (EDT) Original-Received: from critterling.garfield.home (unknown [50.111.97.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id CE9BAE345; Thu, 30 Mar 2017 18:18:49 -0400 (EDT) Original-Received: from [100.95.30.162] (116.sub-174-194-29.myvzw.com [174.194.29.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by critterling.garfield.home (Postfix) with ESMTPSA id 6FAA133A; Thu, 30 Mar 2017 18:18:48 -0400 (EDT) X-Mailer: iPhone Mail (14E277) In-Reply-To: <87tw6axw1e.fsf@linux-m68k.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy] X-Received-From: 64.68.201.169 X-Mailman-Approved-At: Thu, 30 Mar 2017 18:30:43 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213539 Archived-At: Works for me. Glad to re-submit shortly.=20 Best, Victor -- Victor J. Orlikowski <> victor.j.orlikowski@alumni.duke.edu > On Mar 30, 2017, at 6:02 PM, Andreas Schwab wrote:= >=20 >> On M=C3=A4r 30 2017, "Victor J. Orlikowski" wrote: >>=20 >> diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el >> index 488404d..357d03c 100644 >> --- a/lisp/erc/erc.el >> +++ b/lisp/erc/erc.el >> @@ -6735,9 +6735,10 @@ This function should be on `erc-kill-server-hook'.= " >> This function should be on `erc-kill-channel-hook'." >> (when (erc-server-process-alive) >> (let ((tgt (erc-default-target))) >> - (erc-server-send (format "PART %s :%s" tgt >> - (funcall erc-part-reason nil)) >> - nil tgt)))) >> + (unless (not tgt) >=20 > (unless (not)) =3D=3D (when) >=20 > Andreas. >=20 > --=20 > Andreas Schwab, schwab@linux-m68k.org > GPG Key fingerprint =3D 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5= > "And now for something completely different."