From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#6933: 24.0.50; fringe-mode value of `half' is broken Date: Sat, 28 Aug 2010 08:15:29 -0700 Message-ID: References: <97A7C2F12C894D59986BE445D664437A@us.oracle.com> <83r5hjktvz.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1283010679 987 80.91.229.12 (28 Aug 2010 15:51:19 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 28 Aug 2010 15:51:19 +0000 (UTC) Cc: 6933@debbugs.gnu.org To: "'Eli Zaretskii'" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 28 17:51:04 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OpNgH-0007n8-0d for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Aug 2010 17:50:57 +0200 Original-Received: from localhost ([127.0.0.1]:38907 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OpNVQ-0007WK-91 for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Aug 2010 11:39:44 -0400 Original-Received: from [140.186.70.92] (port=41662 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OpNVG-0007V9-EU for bug-gnu-emacs@gnu.org; Sat, 28 Aug 2010 11:39:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OpNVD-0005yD-Re for bug-gnu-emacs@gnu.org; Sat, 28 Aug 2010 11:39:33 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59356) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OpNVD-0005xt-Ls for bug-gnu-emacs@gnu.org; Sat, 28 Aug 2010 11:39:31 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OpN7X-0001PG-5b; Sat, 28 Aug 2010 11:15:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Aug 2010 15:15:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6933 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6933-submit@debbugs.gnu.org id=B6933.12830084475386 (code B ref 6933); Sat, 28 Aug 2010 15:15:03 +0000 Original-Received: (at 6933) by debbugs.gnu.org; 28 Aug 2010 15:14:07 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OpN6c-0001Op-KI for submit@debbugs.gnu.org; Sat, 28 Aug 2010 11:14:06 -0400 Original-Received: from rcsinet10.oracle.com ([148.87.113.121]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OpN6b-0001OT-3O for 6933@debbugs.gnu.org; Sat, 28 Aug 2010 11:14:05 -0400 Original-Received: from rcsinet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id o7SFFYpS022698 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 28 Aug 2010 15:15:35 GMT Original-Received: from acsmt354.oracle.com (acsmt354.oracle.com [141.146.40.154]) by rcsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o7SCF55b011506; Sat, 28 Aug 2010 15:15:34 GMT Original-Received: from abhmt019.oracle.com by acsmt353.oracle.com with ESMTP id 541113101283008527; Sat, 28 Aug 2010 08:15:27 -0700 Original-Received: from dradamslap1 (/10.159.221.84) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 28 Aug 2010 08:15:27 -0700 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <83r5hjktvz.fsf@gnu.org> Thread-Index: ActGjTQuuGlpCwS7T76Ua+3ldsJ8pgANXAqw X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5931 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sat, 28 Aug 2010 11:15:03 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:39801 Archived-At: > > emacs -Q > > > > M-x fringe-mode > > Enter `half'. > > > > The fringe values (both left and right) should each be 5, > > according to the code and comments. Instead, it is still 8, > > as shown by (frame-parameters). There is no difference in behavior > > between `half' and `default'. Dunno whether this is Windows-specific. > > This happens because fringe.el has this customization form for "half" > in the defcustom for fringe-mode: > > (const :tag "Half width" (5 . 5)) > > And the doc string for fringe-mode says this, among the rest: > > This command may round up the left and > right width specifications to ensure that their sum is a multiple > of the character width of a frame. > > So 5 is rounded up to 8, and the rest is history. > > I don't know why the values are 5 instead of 4. The default fringe > width is 8 on all GUI displays, so half of that should have been 4, > not 5. Maybe I'm missing some subtlety here. > > Can someone please check on X whether (fringe-mode '(4 . 4)) does TRT? > If it does, I think we should use 4 instead of 5 in the above > defcustom. Thanks. Default is 8; half is 5, which results in 8 (same as default); and minimal is 4. If we have 3 values (choices) and the default is 8, then the values should ideally give 3 different appearances (effects). Neither {8,8,4} and {8,4,4} is a good set. But since both minimal and half show both left and right fringes, and the sum must be a multiple of the frame char width (default 8), that doesn't leave a lot of choice. Presumably, for both minimal and half you want the left and right to be the same, and 8/2 = 4. So I guess there is no good solution. But perhaps this could be better explained in the doc. I'd suggest making half be 4, at least, since users expect it to be less than default (whole) in appearance. It is less disconcerting if users see no difference between half and minimal when using the default frame-char size: "minimal" does not imply less than half, but "half" implies less than whole (default). Also, "default" might not be the best term here. I don't have a great suggestion, however. Maybe "full", "whole", or "maximal", but each of those has its drawbacks too.