From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#74277: 29.4; rust-ts-mode doesn't highlight some function calls Date: Wed, 1 Jan 2025 19:17:22 -0800 Message-ID: References: <86bjyookld.fsf@gnu.org> <87r077kl0n.fsf@gmail.com> <87ed3522aj.fsf@gmail.com> <87bjy5yuaz.fsf@gmail.com> <89EB0889-DD32-40C2-92E3-8A89ABB6EE37@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30794"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Randy Taylor , Eli Zaretskii , 74277@debbugs.gnu.org, acidbong@tilde.club To: Trevor Arjeski Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 02 04:18:25 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tTBj7-0007sH-AN for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Jan 2025 04:18:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tTBj3-0004LA-Fc; Wed, 01 Jan 2025 22:18:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTBik-0004Jz-Dk for bug-gnu-emacs@gnu.org; Wed, 01 Jan 2025 22:18:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tTBik-0008FX-3s for bug-gnu-emacs@gnu.org; Wed, 01 Jan 2025 22:18:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:Date:In-Reply-To:From:Mime-Version:To:Subject; bh=LHRTQXghrhv48rapjABL/2+zNcHopiSVE74O2pnO7W8=; b=kAVhrtZ0WZvlEotz/d40ZGyKsqlpV/KqxHJ31tNqchm3v1Hie4DUKiuYE8t8QKB2iaP0IJ26FTGclJyMGdS4FgFLP2VjpNPUIuno9I9X3WGS+XogyYSELVHF/s8VvkerNedowqu2Y0hli8Gfrgvc1r2H6fSy7a0Kiupt0SW6NKau6NyAGN2gvU/KJC0jZcowwosgGOa0dGfYrt5t/FOOHOih4/7VGfLe3sxrHDotFHV+mogC56aVYSIWK/Q2Pyphr+yXu4IPpIHSSMDttO9aRkZxOgWcWXB6GCDMURSfDkHsX/xUFtHZ+B2SZeNdcNSQ9pjyfPbn5vCx1fJbXS8JZQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tTBij-000650-Tp for bug-gnu-emacs@gnu.org; Wed, 01 Jan 2025 22:18:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Jan 2025 03:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74277 X-GNU-PR-Package: emacs Original-Received: via spool by 74277-submit@debbugs.gnu.org id=B74277.173578786023337 (code B ref 74277); Thu, 02 Jan 2025 03:18:01 +0000 Original-Received: (at 74277) by debbugs.gnu.org; 2 Jan 2025 03:17:40 +0000 Original-Received: from localhost ([127.0.0.1]:41645 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tTBiN-00064J-AA for submit@debbugs.gnu.org; Wed, 01 Jan 2025 22:17:39 -0500 Original-Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]:56564) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tTBiJ-000649-Cr for 74277@debbugs.gnu.org; Wed, 01 Jan 2025 22:17:36 -0500 Original-Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-2163b0c09afso145255015ad.0 for <74277@debbugs.gnu.org>; Wed, 01 Jan 2025 19:17:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735787854; x=1736392654; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=LHRTQXghrhv48rapjABL/2+zNcHopiSVE74O2pnO7W8=; b=P2huWyERGbpNK1Btl1vuGh+tbFopYNC1SJUmOC5SbQVgGErrphNnj6G/eZy4ch8+I6 B4QqJz1nOG02qQljAu/UA/q1w519mjiKOv4fb8JEiMmZYSbuybZDPkLPNqbOxx8UbuNS SQtboxhsKpmUHOEMaPX4F9k6RJX4/m2pbuXLyjy21xOWsAC4HSYw29rIThp9B21r7Fjc WJ9ujPCWRUvDwd050+g3ceaHufpc8fWq3XPjrKboyhG8f6GfGWrepaTcDaqEbiNOzzK2 CHRuxkBN2tpGC0D/xPyiOx790nsob7XKs2lJpU/7qod+2TvP4KWmJKyzKcxuSMLP02aH JZZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735787854; x=1736392654; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LHRTQXghrhv48rapjABL/2+zNcHopiSVE74O2pnO7W8=; b=XPuctVn1g61DF621mVW0Mk6DtLkgE4HNqtd9yA1IJDaJIaq4Y4jKK9xjJkhp7r1Ybb ZxmKtTTbjnkg4wsP9auENGjbUv4OCSN4FjxuvP2FMq2zrGTgJS8ddI4UHNXjtogLmrhc E8muFRIxCfxKMaBYLOT6e4BNT7tkWpG/F82GRhhfhxxHEK2G+m8vSA7ytUWxqv6drTa2 R9Nt8VZQWPWL7Z5ZLEv0vuogVEchtTycK0ComnndrcDTwWhPII8QNUl6OVeUBPuMGcHM X/oXMjrstyW2Ak7zsYTbJ3XUFerQTHwWYiIJLZ1Wg8UZ9WV87neAdPCRmsV4a2oPdNp2 +zPQ== X-Forwarded-Encrypted: i=1; AJvYcCVMCqJhAtOEmS9xaM2YzhFXEdsqxkf32E906Xtci7j56cE3F2U7cxzk9tYKX/BlmI1/Lfzk4g==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwsoaZofcW8nwr5O9YxrRtHWkuJubn+tq5szyL8bM6n8jwaLGx1 xfvLTXKN1GqkXctm6htskp76MfoYSiY6O3os2MD9sV62gtxoxIh0 X-Gm-Gg: ASbGncu/y9dNyvL+hIzFHtntt4AAD6xm48NjX2P3125xWM79REo4yrwmJ4kpD4jnh4h jwsZ42S80ua/3hshBER3+1Q+/vql3HsjxLnoJkGF8aKAXprK1JgKSFV9yvvfuYP7H3zu816DYkU N1NYan2ZWIZejqGuWE+eIKZRNjold0wlUZqXBBQaVI1djE4nM3H0k1PVFWEqTvnRG/csKwVhGQd ozI9PKPajvDJDIfcIr26IQW0roruRbCI3CHjHX17Hx+ljvRNDXJ3KfuVEkUVkCUVt9AW1eLM+BY Gwzf X-Google-Smtp-Source: AGHT+IGPFnUYWnLvVKSCdb/YQLR/I4kZxdsVfABIIewYZLNJsAcmA399kbjfx9u6zb3WudVgUQq3nw== X-Received: by 2002:a05:6a20:e68b:b0:1e1:72ce:fefc with SMTP id adf61e73a8af0-1e5e05a9edemr79269168637.22.1735787854074; Wed, 01 Jan 2025 19:17:34 -0800 (PST) Original-Received: from smtpclient.apple ([2601:646:8f81:6120:85eb:71bd:58ac:56a8]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72aad8157d7sm23979942b3a.21.2025.01.01.19.17.32 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Jan 2025 19:17:33 -0800 (PST) In-Reply-To: <89EB0889-DD32-40C2-92E3-8A89ABB6EE37@gmail.com> X-Mailer: Apple Mail (2.3776.700.51) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298108 Archived-At: > On Nov 24, 2024, at 11:34=E2=80=AFPM, Yuan Fu = wrote: >=20 >=20 >=20 >> On Nov 23, 2024, at 11:17=E2=80=AFPM, Trevor Arjeski = wrote: >>=20 >> Yuan Fu writes: >>=20 >>>> On Nov 21, 2024, at 7:30=E2=80=AFPM, Randy Taylor = wrote: >>>>=20 >>>> On Wednesday, November 20th, 2024 at 13:22, Trevor Arjeski = wrote: >>>>>=20 >>>>> Trevor Arjeski tmarjeski@gmail.com writes: >>>>>=20 >>>>>=20 >>>>> I decided to hack around with this a little bit and found that = adding >>>>> the following lines partially works: >>>>>=20 >>>>>=20 >>>>> I'm sure there is an issue with solving it this way, I just need = someone >>>>> else more experienced to confirm. It is finicky where it turns the >>>>> highlighting on and off when you make some code changes, for = example >>>>> adding and removing the semi-colon after the macro invocation. >>>>=20 >>>> Yuan would be the best to answer that. >>>=20 >>> Using injection (what Emacs calls local parser, same thing) here is = fine, I >>> think. As Randy said, tree-sitter doesn=E2=80=99t have a good answer = for macros. If nvim >>> uses this workaround (create an injection for the macro and parses = it like >>> normal rust code), then it should be fine for us to follow suit. >>>=20 >>=20 >> Any ideas why my crude implementation of the injection "flickers" on = and >> off after certain changes? >>=20 >> Thanks, >> Trevor >=20 > So, after spending a night on this, it appears to be a tree-sitter bug = :( I created an issue here: = https://github.com/tree-sitter/tree-sitter/issues/3962 According to tree-sitter devs, the tree-sitter bug should be fixed now. Yuan=