From: "Jan D." <jan.h.d@swipnet.se>
To: David Caldwell <david@porkrind.org>
Cc: 19850@debbugs.gnu.org
Subject: bug#19850: 25.0.50; [PATCH] configure.ac: Fix site-lisp paths with NS self-contained apps.
Date: Fri, 13 Feb 2015 07:57:13 +0100 [thread overview]
Message-ID: <C1F005FC-36F8-4B5F-A6E5-A81A46165EB6@swipnet.se> (raw)
In-Reply-To: <54DD2060.2000909@porkrind.org>
Hi.
If we keep site-lis as it is, we can have several Emacs versions installed, with different site-lisp:s. Also, changing files in site-lisp does not require root priviliges.
Your change breaks both those feaures.
I don't think this is a good idea.
Jan D.
> 12 feb 2015 kl. 22:51 skrev David Caldwell <david@porkrind.org>:
>
>
> When building a self contained Mac OS X app, the site-lisp dir that gets
> inserted into `load-path` is not very useful, since it points to the
> Emacs.app in `nextstep/` where emacs was compiled. For example:
>
> "/Users/build/workspace/Emacs-Multi-Build/label/mavericks/emacs-source/nextstep/Emacs.app/Contents/Resources/share/emacs/24.4/site-lisp"
>
> I think the site lisp path should be in `/Library/emacs` instead. Here
> is a patch to do just that (created with `git format-patch`, is that
> convenient? I don't know what works best in these cases).
>
> I patched the trunk, but on reflection, it seems like this should go in
> the 24 branch, too.
>
> -David
>
> From c20e8816f3905fa3ec6f82a7f566f7ce32dc178b Mon Sep 17 00:00:00 2001
> From: David Caldwell <david@porkrind.org>
> Date: Thu, 12 Feb 2015 13:31:36 -0800
> Subject: [PATCH] configure.ac: Fix site-lisp paths with NS self-contained
> apps.
>
> * configure.ac (HAVE_NS): When self-contained, set datarootdir to
> /Library so PATH_SITELOADSEARCH path points there instead of inside
> the Emacs.app build dir.
> ---
> configure.ac | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/configure.ac b/configure.ac
> index 68291b8..3e44a93 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1872,6 +1872,8 @@ if test "${HAVE_NS}" = yes; then
> mandir="\${ns_appresdir}/man"
> lispdir="\${ns_appresdir}/lisp"
> INSTALL_ARCH_INDEP_EXTRA=
> + # This is so PATH_SITELOADSEARCH gets set to /Library/emacs/...
> + datarootdir=/Library
> fi
>
> NS_OBJC_OBJ="nsterm.o nsfns.o nsmenu.o nsselect.o nsimage.o $ns_fontfile"
> --
> 2.2.2
> <mac-site-lisp-path.patch>
next prev parent reply other threads:[~2015-02-13 6:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 21:51 bug#19850: 25.0.50; [PATCH] configure.ac: Fix site-lisp paths with NS self-contained apps David Caldwell
2015-02-13 6:57 ` Jan D. [this message]
2015-02-13 7:28 ` David Caldwell
2015-02-13 13:41 ` Jan D.
2015-02-13 19:41 ` David Caldwell
2015-02-14 9:25 ` Jan D.
2015-02-14 10:09 ` David Caldwell
2015-02-13 16:36 ` Jan D.
2015-02-13 16:46 ` Jan D.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C1F005FC-36F8-4B5F-A6E5-A81A46165EB6@swipnet.se \
--to=jan.h.d@swipnet.se \
--cc=19850@debbugs.gnu.org \
--cc=david@porkrind.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.