From: Yuan Fu <casouri@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: [ELPA] New package xeft.el
Date: Tue, 10 Jan 2023 02:57:14 -0800 [thread overview]
Message-ID: <C1E18AB9-A97B-4F37-918C-6765562D6FFD@gmail.com> (raw)
In-Reply-To: <jwvy1qfmysa.fsf-monnier+emacs@gnu.org>
> On Jan 6, 2023, at 8:21 AM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>
>> Yeah I can do that. The download feature is probably over-engineering
>> for not much benefit :-)
>
> It's beneficial for those who don't have a local C/C++ compiler.
> With the requirements of native compilation, this may become less of an
> issue, but still, it's something that's been requested fairly often
> (mostly by package maintainers rather than by users, admittedly, but
> still).
>
>>> Other details I saw along the way:
>>> - You claim you have precompiled packages for GNU/Linux but that's only
>>> true for amd64, which is only a particular subset of GNU/Linux
>>> (most of my GNU/Linux machines (i386, armhf, arm64) are outside of
>>> that subset, for example).
>> That’s true, probably better to not have the download feature.
>
> At the same time amd4 covers probably the vast majority of users.
>
> Maybe elpa.gnu.org could be used to host precompiled binaries.
> Our Free Software ideals tell us we should expose the source code as
> much as possible so I think "download binary" should be an alternative
> to "compile the source" rather than to "download the source", so the
> first point is to include the source code in the ELPA package.
>
> We may even be able to make elpa.gnu.org generate precompiled binaries
> for armhf, i386, and arm64 (it's fairly easy to install those
> cross-compilation tools under Debian). But this won't happen until
> someone writes the code for that.
>
>>> - Your source code includes `emacs-module.h` which should not be
>>> necessary because that file is distributed with Emacs (the way `pq`
>>> finds it is not ideal, but this might be a good opportunity to look
>>> at improving the situation and providing a standardized way for
>>> ELisp packages to find that file).
>>
>> Is it included in the distributed Emacs?
>
> Yes.
>
>> I thought you would need the source of Emacs to access that file.
>
> No, `make install` copies it to a "sane" place.
> But I don't (yet?) know how to reliably find that place from the running Emacs.
Even if you can, I’d say ideally you want to be able to compile a dynamic module without a running Emacs.
I:
- added copyright notice to xapian-lite.cc
- added xapian-lite.cc (and friends) to the source repository of xeft, so the user can compile the dynamic module (xapian-lite) without downloading the source of it.
- didn’t do anything about emacs-module.h.
- changed the wording of some prompts of the compile/download process
Yuan
next prev parent reply other threads:[~2023-01-10 10:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 4:11 [ELPA] New package xeft.el Yuan Fu
2023-01-04 8:08 ` Jean Louis
2023-01-04 16:46 ` Fu Yuan
2023-01-06 17:34 ` Jean Louis
2023-01-10 10:48 ` Yuan Fu
2023-01-04 19:24 ` Stefan Monnier
2023-01-04 19:38 ` Karl Fogel
2023-01-06 5:48 ` Yuan Fu
2023-01-06 5:46 ` Yuan Fu
2023-01-06 16:21 ` Stefan Monnier
2023-01-10 10:57 ` Yuan Fu [this message]
2023-01-13 4:51 ` Richard Stallman
2023-01-13 9:54 ` Dr. Arne Babenhauserheide
2023-01-15 5:14 ` Richard Stallman
2023-01-16 7:48 ` Dr. Arne Babenhauserheide
2023-01-17 4:57 ` Richard Stallman
2023-01-17 11:53 ` Eli Zaretskii
2023-01-23 4:23 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C1E18AB9-A97B-4F37-918C-6765562D6FFD@gmail.com \
--to=casouri@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.