From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#59490: 29.0.50; Add C# support Date: Wed, 23 Nov 2022 12:38:19 -0800 Message-ID: References: <87edtuogp6.fsf@thornhill.no> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25106"; mail-complaints-to="usenet@ciao.gmane.io" Cc: theo@thornhill.no, 59490@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 23 21:39:29 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxwWi-00065I-Tw for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Nov 2022 21:39:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxwWP-0005fP-Mk; Wed, 23 Nov 2022 15:39:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxwWN-0005fA-46 for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 15:39:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxwWM-0007Nw-GL for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 15:39:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oxwWM-0007Na-7i for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 15:39:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87edtuogp6.fsf@thornhill.no> Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Nov 2022 20:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59490 X-GNU-PR-Package: emacs Original-Received: via spool by 59490-submit@debbugs.gnu.org id=B59490.166923591228326 (code B ref 59490); Wed, 23 Nov 2022 20:39:02 +0000 Original-Received: (at 59490) by debbugs.gnu.org; 23 Nov 2022 20:38:32 +0000 Original-Received: from localhost ([127.0.0.1]:56377 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxwVr-0007Mn-TS for submit@debbugs.gnu.org; Wed, 23 Nov 2022 15:38:32 -0500 Original-Received: from mail-pf1-f172.google.com ([209.85.210.172]:34438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxwVn-0007MW-0b for 59490@debbugs.gnu.org; Wed, 23 Nov 2022 15:38:30 -0500 Original-Received: by mail-pf1-f172.google.com with SMTP id z26so18406770pff.1 for <59490@debbugs.gnu.org>; Wed, 23 Nov 2022 12:38:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=MrD0eQoqDILTTw8kDCKzCP++8pbK+xAgsUhrSxBNhI8=; b=Zreer/4O1Zdh1WIl2ZA92jd4YV9QOAbzwqGFZB7jezbVpzWL4fW6KeUGTyBFJ8Xa2a BMQ1BFAgCwtf9bFKtsOwFq92BgS8RT5KrBlEhyZGyWBT/I3PcCL9z7SmZgPDymK7y5HR YVXChzsZzL/JeAtZEq8I7jGMTM1TNOO6HBYkFMNBVrGadqgWYD+iIYHRV2xboIZntcFA hd6LnPU1cVygaL2reyOyrewbURTIWmAH9hobsTqFcY8qyBoO+vNYjA+ZaGhnFzIgJut0 WXGyoViCeHnUK+cUhv4qbPfz4qyNgz23RqZ02SdD7+bxotWpfPEfvx90HTCudW1o0Wma 9B/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MrD0eQoqDILTTw8kDCKzCP++8pbK+xAgsUhrSxBNhI8=; b=rF8OtZmP3DboRyawVYskrSky1bj6bAXMzeoMZW3eCxAezHsBciQYvcZh9wQ/S4SF5a DJLjIUrx83MNIW5LTmkIu+PJw/4nst5Rm/QaEqwr8hNPgT+9+EThGVn+lzFLeVPFxvEW L47ok6MLWy/r6rZBa0v2GDaSEiDte98wiR5SbC001tZoB10MMcQFOLH6mLL1K7gATM9k bC6rf1kiTeFDBBqUCNqsFG1Oo6q9+ZfcK9Ctq4cx3qflwQ8jeDDIu4tkaTTfZebhkQQ2 OOZIfs/hL553Oq8UPIndKxsb8vHraTim0V5j7GPb11JPAT3obeNhIZEUwXUdx7GwSugO cxSw== X-Gm-Message-State: ANoB5pkZxLVcK+XeCN6+GD+0XuOmk70c/9rURu8LeIogQH+DYWdI2RqI jWJq6d2IWSFVbOztze7HioY= X-Google-Smtp-Source: AA0mqf6YL9p+tfYHZF35uP1n2AlWQ5Hbl8JhxpK4NHGrYtslzAVRjGAVMz8sUWc16ZDE31MOVzC1jA== X-Received: by 2002:a63:e84f:0:b0:477:7dc8:57a7 with SMTP id a15-20020a63e84f000000b004777dc857a7mr8956989pgk.498.1669235900906; Wed, 23 Nov 2022 12:38:20 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id i8-20020a170902c94800b00172fad607b3sm14845716pla.207.2022.11.23.12.38.20 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Nov 2022 12:38:20 -0800 (PST) X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248785 Archived-At: Yuan Fu writes: > Eli Zaretskii writes: > >>> Date: Tue, 22 Nov 2022 22:47:12 +0100 >>> From: Theodor Thornhill via "Bug reports for GNU Emacs, >>> the Swiss army knife of text editors" >>>=20 >>> Ok so this works. >>>=20 >>> Sorry for the mess. >>>=20 >>> What do you think? >> >> LGTM, thanks. I'll let Yuan review and install. > > Thanks Theo! I=E2=80=99ve merged it. One general comment is that we = should have > a "standard" list of features consistent across major modes. I think = by > now we=E2=80=99ve worked on font-lock enough to know what those = features should > be. I=E2=80=99ll start a discussion on the ML. Actually, another thing: it seems the mode defined is still named csharp-mode rather than csharp-cc-mode. Yuan