From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#14176: 24.3.50; `bookmark-completing-read': prompt and return value for "" DEFAULT Date: Sat, 13 Apr 2013 08:46:32 -0700 Message-ID: References: <7707C9A29C4748B093E2167A99592511@us.oracle.com><87txnda9qd.fsf@gmail.com><87ehegjokl.fsf@gmail.com><0C53172999584A498FB4190ADC8990CB@us.oracle.com> <87zjx2n8vy.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1365868023 30196 80.91.229.3 (13 Apr 2013 15:47:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 13 Apr 2013 15:47:03 +0000 (UTC) Cc: 14176@debbugs.gnu.org To: "'Thierry Volpiatto'" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 13 17:47:07 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UR2fS-00083F-5J for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 Apr 2013 17:47:06 +0200 Original-Received: from localhost ([::1]:54138 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UR2fR-0007wh-RW for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 Apr 2013 11:47:05 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:57079) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UR2fO-0007vf-IK for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2013 11:47:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UR2fN-0002tw-Kv for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2013 11:47:02 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44751) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UR2fN-0002tq-HL for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2013 11:47:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UR2jF-0000EW-Jj for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2013 11:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Apr 2013 15:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14176 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14176-submit@debbugs.gnu.org id=B14176.1365868248873 (code B ref 14176); Sat, 13 Apr 2013 15:51:01 +0000 Original-Received: (at 14176) by debbugs.gnu.org; 13 Apr 2013 15:50:48 +0000 Original-Received: from localhost ([127.0.0.1]:48860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UR2j2-0000E2-23 for submit@debbugs.gnu.org; Sat, 13 Apr 2013 11:50:48 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:40975) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UR2j0-0000Dv-CZ for 14176@debbugs.gnu.org; Sat, 13 Apr 2013 11:50:47 -0400 Original-Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r3DFkhmB026119 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 13 Apr 2013 15:46:44 GMT Original-Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r3DFkhGf004884 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Sat, 13 Apr 2013 15:46:43 GMT Original-Received: from abhmt119.oracle.com (abhmt119.oracle.com [141.146.116.71]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r3DFkhLM010278; Sat, 13 Apr 2013 15:46:43 GMT Original-Received: from dradamslap1 (/71.202.147.44) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 13 Apr 2013 08:46:42 -0700 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87zjx2n8vy.fsf@gmail.com> Thread-Index: Ac44Hyn+8Y37y0hdQbSfCrGgxcZjUwAPPXSw X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:73379 Archived-At: > Here with the docstring modified, if you want to modify the docstring > (or something else), provide a patch to allow Stefan to apply the > changes. Looks good to me, thanks. I would still suggest that we use (if (consp default) (car default) default) instead of just `default', in the `format' sexp, to allow for a cons DEFAULT value. There is no reason not to, IMO. A caller might pass, for example, a list of (a) the current bookmark, (b) a bookmark mentioned in text at point, (c) the bookmark whose target location is closest to point... Or a caller might pass a list of bookmarks with targets in the current buffer/file. And so on. But that enhancement, though trivial, is outside this bug report. And if/when we do that, it would also be good to update the doc string to mention that DEFAULT can be a cons (as in `completing-read').