bug#3578: 23.0.94; when saving some files, diff does not work

bug#3578: 23.0.94; when saving some files, diff does not work

[Tiago Saboga]

Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

I start emacs with -q and -no-site-file, visit some file, make some
changes, switch to buffer "scratch" (or any other buffer with no
associated file) and run save-some-buffers. It asks me what to do with
the visited file, and I want to view the diff, so I press "d".  And I
get an error message: "Not applicable: no file."

I believe that the problem was introduced by revision 1.985 of files.el,
line 4178, that says:

(if (null buffer-file-name)

and should say:

(if (null buffer-file-name buf)

Thanks,

Tiago Saboga.

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/usr/share/emacs/23.0.94/etc/DEBUG for instructions.


In GNU Emacs 23.0.94.1 (x86_64-pc-linux-gnu, GTK+ Version 2.16.1)
 of 2009-05-25 on elegiac, modified by Debian
 (emacs-snapshot package, version 1:20090525-1)
Windowing system distributor `The X.Org Foundation', version 11.0.10402000
configured using `configure  '--build' 'x86_64-linux-gnu' '--host' 'x86_64-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/23.0.94/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.0.94/site-lisp:/usr/share/emacs/site-lisp' '--with-x=yes' '--with-x-toolkit=gtk' 'build_alias=x86_64-linux-gnu' 'host_alias=x86_64-linux-gnu' 'CFLAGS=-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2' 'LDFLAGS=-g -Wl,--as-needed' 'CPPFLAGS=''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: pt_BR.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Alunos

Minor modes in effect:
  show-paren-mode: t
  display-time-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent messages:
Saving /home/tiago/.newsrc.eld...
Saving file /home/tiago/.newsrc.eld...
Wrote /home/tiago/.newsrc.eld
Saving /home/tiago/.newsrc.eld...done

bug#3578: 23.0.94; when saving some files, diff does not work

[Drew Adams]

> I believe that the problem was introduced by revision 1.985 
> of files.el, line 4178, that says: (if (null buffer-file-name)
> and should say: (if (null buffer-file-name buf)

You probably mean (if (null (buffer-file-name buf)))

bug#3578: 23.0.94; when saving some files, diff does not work

[Tiago Saboga]

On Mon, Jun 15, 2009 at 3:14 PM, Drew Adams<drew.adams@oracle.com> wrote:
>> I believe that the problem was introduced by revision 1.985
>> of files.el, line 4178, that says: (if (null buffer-file-name)
>> and should say: (if (null buffer-file-name buf)
>
> You probably mean (if (null (buffer-file-name buf)))

Yes, of course. Sorry, I was in a hurry, and I felt I would forget it
if did not send the report immediately. I have tested it now and it
seems to work fine.

Tiago.

bug#3578: marked as done (23.0.94; when saving some files, diff does not work)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 894 bytes --]


Your message dated Wed, 17 Jun 2009 11:07:30 -0400
with message-id <87skhyzyod.fsf@stupidchicken.com>
and subject line Re: 23.0.94; when saving some files, diff does not work
has caused the Emacs bug report #3578,
regarding 23.0.94; when saving some files, diff does not work
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
3578: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3578
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 5881 bytes --]

From: Tiago Saboga <tiagosaboga@gmail.com>
To: emacs-pretest-bug@gnu.org
Cc: rfrancoise@debian.org
Subject: 23.0.94; when saving some files, diff does not work
Date: Mon, 15 Jun 2009 14:03:02 -0300
Message-ID: <87eitl1lbt.fsf@sofocles.comuna.andre>


Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

I start emacs with -q and -no-site-file, visit some file, make some
changes, switch to buffer "scratch" (or any other buffer with no
associated file) and run save-some-buffers. It asks me what to do with
the visited file, and I want to view the diff, so I press "d".  And I
get an error message: "Not applicable: no file."

I believe that the problem was introduced by revision 1.985 of files.el,
line 4178, that says:

(if (null buffer-file-name)

and should say:

(if (null buffer-file-name buf)

Thanks,

Tiago Saboga.

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/usr/share/emacs/23.0.94/etc/DEBUG for instructions.


In GNU Emacs 23.0.94.1 (x86_64-pc-linux-gnu, GTK+ Version 2.16.1)
 of 2009-05-25 on elegiac, modified by Debian
 (emacs-snapshot package, version 1:20090525-1)
Windowing system distributor `The X.Org Foundation', version 11.0.10402000
configured using `configure  '--build' 'x86_64-linux-gnu' '--host' 'x86_64-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/23.0.94/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.0.94/site-lisp:/usr/share/emacs/site-lisp' '--with-x=yes' '--with-x-toolkit=gtk' 'build_alias=x86_64-linux-gnu' 'host_alias=x86_64-linux-gnu' 'CFLAGS=-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2' 'LDFLAGS=-g -Wl,--as-needed' 'CPPFLAGS=''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: pt_BR.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Alunos

Minor modes in effect:
  show-paren-mode: t
  display-time-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent messages:
Saving /home/tiago/.newsrc.eld...
Saving file /home/tiago/.newsrc.eld...
Wrote /home/tiago/.newsrc.eld
Saving /home/tiago/.newsrc.eld...done


[-- Attachment #3: Type: message/rfc822, Size: 1863 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: Tiago Saboga <tiagosaboga@gmail.com>
Cc: 3578-done@emacsbugs.donarmstrong.com
Subject: Re: 23.0.94; when saving some files, diff does not work
Date: Wed, 17 Jun 2009 11:07:30 -0400
Message-ID: <87skhyzyod.fsf@stupidchicken.com>

> I start emacs with -q and -no-site-file, visit some file, make some
> changes, switch to buffer "scratch" (or any other buffer with no
> associated file) and run save-some-buffers. It asks me what to do with
> the visited file, and I want to view the diff, so I press "d".  And I
> get an error message: "Not applicable: no file."

Thanks for finding this problem, and debugging it.  I've checked in the
fix.