From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#62951: 29.0.90; c-ts-mode: Incorrect fontification due to FOR_EACH_TAIL_SAFE Date: Mon, 24 Apr 2023 00:02:03 -0700 Message-ID: References: <82E7ADEC-25BC-475B-8EE0-839FE78FF2F4@gmail.com> <83fs8s2xnk.fsf@gnu.org> <2BDA88D0-A870-4FE3-BAF8-350FBAA943BF@gmail.com> <83sfcryv23.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.500.231\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27980"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62951@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 24 09:03:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pqqEQ-00072n-Ej for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 24 Apr 2023 09:03:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pqqE5-0003gj-Ho; Mon, 24 Apr 2023 03:03:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pqqE3-0003gJ-Sj for bug-gnu-emacs@gnu.org; Mon, 24 Apr 2023 03:03:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pqqE3-0005oQ-IB for bug-gnu-emacs@gnu.org; Mon, 24 Apr 2023 03:03:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pqqE1-00023o-Ok for bug-gnu-emacs@gnu.org; Mon, 24 Apr 2023 03:03:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Apr 2023 07:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62951 X-GNU-PR-Package: emacs Original-Received: via spool by 62951-submit@debbugs.gnu.org id=B62951.16823197437875 (code B ref 62951); Mon, 24 Apr 2023 07:03:01 +0000 Original-Received: (at 62951) by debbugs.gnu.org; 24 Apr 2023 07:02:23 +0000 Original-Received: from localhost ([127.0.0.1]:47355 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqqDP-00022w-Bb for submit@debbugs.gnu.org; Mon, 24 Apr 2023 03:02:23 -0400 Original-Received: from mail-pl1-f172.google.com ([209.85.214.172]:58517) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqqDN-00022j-IP for 62951@debbugs.gnu.org; Mon, 24 Apr 2023 03:02:22 -0400 Original-Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1a6862e47b1so46232615ad.0 for <62951@debbugs.gnu.org>; Mon, 24 Apr 2023 00:02:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682319735; x=1684911735; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=3r5z72xr+Ur/yOgCf0Zx6xiqCet4mcEtyslqb8dnCg0=; b=o+8HcxV0nNUg+28h39CuKKZ1nhf6er6CQnB5pTycBCPziL7fxb6IIXpqf3v5advrIA RAXvhd3i0BgeDRxjMATa9M9vP5eDtNQQ1MZ901TSusvJDajAfTqFs297CKDkH1HGz+cp qh0QxzWkrsSZbmWE+BvL0plfefK7o8gl79AtdzH3nMR9fOqjKGcWEpsxtdkQDDBXB6xP o4GXjTPM/D1gvH7KsFQ+OdoZPD6l7T7QtFQIOzPl4rqW1m790uVFlFw99q5YHX06DtZj CdZrvOQwHJ0DLaBjqaCuGl4fysrJ1IYk3hLVqzn2F0VsAJEQWECvHmoB9Ntgr81CiYC+ 9OrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682319735; x=1684911735; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3r5z72xr+Ur/yOgCf0Zx6xiqCet4mcEtyslqb8dnCg0=; b=XWIfOr7kXRj4hYPk371GmmkdnhH2jnjqENcAjjd6OIByuJH6f63g3jlByalSkC7i0B YT9pWTri9JEHsEcUlXN6M05PjGMI0MY1sT6xqvM0028ENphRqeT55k0pjsQiGrxlxZiX 8u/Tj3JR2PLjjfOSmoQIKECTZiKLJ7+SFr7TH9ZtqsmIlZG2Exk4O4w5u+L9ZhQ/4AzQ B8u7mlzuEKtsr3+h+HQuxlN2Hp4ZAgodqx0bdkZQUqim+Ht/GuFd0KRFRaNK+I7kDkVI TCG+1Jr5T/EN9MITsvObqHjQfAHSevLcMhsmlqWyxAxvyI+IQqwXWMiaxpuSQHSEbh/r J6yg== X-Gm-Message-State: AAQBX9eLphL2CBV3paCoe5zPqeFy+mZXKMK6oBpjo4D2Av0+1giC6YVI fU4Q89sKejZiyCmoDwukBks= X-Google-Smtp-Source: AKy350a/GfqiQLkOvoCI/Jc8U6S/skJcUF9WGKtK/Lrmyh4adZroNuH+jz+Cwu7tCjPeKQ0EM/TkOw== X-Received: by 2002:a17:902:8215:b0:1a5:5e7:a1cc with SMTP id x21-20020a170902821500b001a505e7a1ccmr12088172pln.58.1682319735263; Mon, 24 Apr 2023 00:02:15 -0700 (PDT) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id d3-20020a170902b70300b001a1deff606fsm5981807pls.125.2023.04.24.00.02.14 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Apr 2023 00:02:14 -0700 (PDT) In-Reply-To: <83sfcryv23.fsf@gnu.org> X-Mailer: Apple Mail (2.3731.500.231) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260548 Archived-At: > On Apr 22, 2023, at 11:25 PM, Eli Zaretskii wrote: >=20 >> From: Yuan Fu >> Date: Sat, 22 Apr 2023 17:28:25 -0700 >> Cc: 62951@debbugs.gnu.org >>=20 >>>> I=E2=80=99m aware of this issue, but the truth is there isn=E2=80=99t= a good solution to >>>> it. We need to recognize FOR_EACH_TAIL_SAFE (not hard) and fix = arbitrary >>>> code after it (hard). In this case it=E2=80=99s a if statement, = with macro calls >>>> and AND operation in it=E2=80=99s condition, it=E2=80=99s already = three things we need >>>> to recognize and somehow handle. It can also be a for loop, a = switch >>>> case, a function call, a while loop. If we want to fix = FOR_EACH_TAIL we >>>> would need to handle every possible thing, at that point we might = as >>>> well have wrote a parser :-) >>>=20 >>> Sorry, I don't understand the difficulties. The body of = FOR_EACH_TAIL >>> and a few similar macros we use could be on of the following: >>>=20 >>> . a single simple statement >>> . an 'if' clause >>> . a 'while' loop >>> . a 'do' loop >>> . a 'for' loop >>> . a brace-delimited block (this one already works, AFAICS, so we >>> perhaps need not anything about it) >>>=20 >>> (In practice, only the first 2 and the last one are used, AFAICS.) >>>=20 >>> Doesn't tree-sitter tell us enough to figure out which of the above = is >>> in the body? If so, why would we need to write a full parser? >>=20 >> Ok, the full parser part is a bit exaggeration :-) But my point is = it=E2=80=99s a lot of dirty code for a subpar result. Take >>=20 >> if (NILP (XCDR (tail)) && STRINGP (XCAR (tail))) >>=20 >> for example, it=E2=80=99s parsed as a function definition and all the = tokens in the condition are parsed as weird things like macro = declarator, error, function declarator, type, etc. And if the condition = changes to something else, say it has another layer of function call, = it=E2=80=99ll parse differently. >=20 > But the top-level construct is 'if', no? Isn't that enough? >=20 > Also, can we detect the FOR_EACH_TAIL etc. macros themselves, and then > treat their body specially? >=20 >>> Please understand: good support for editing Emacs C sources is from = my >>> POV imperative for c-ts-mode to gain traction. One of my gripes = about >>> CC Mode was insufficient support for our macro system and for = various >>> GCC attributes; that improved recently to some extend, but not = enough, >>> and at a price of introducing ugly lists of strings that cause = trouble >>> when used in file-local variables. We must do better in c-ts-mode! >>>=20 >>> So please make an effort of providing reasonable built-in solutions >>> for these idiosyncrasies of the Emacs C sources, conditioned on the >>> new variable c-ts-mode-emacs-sources-support, at least for those of >>> them that are used widely enough. It is very important. >>=20 >> What do you think of extending the parser to support these macros = instead? (So we fork tree-sitter-c.) >=20 > This goes against the purpose of using tree-sitter and its grammars. > I don't think we should maintain and develop language grammars, > especially since the production of the C sources from them needs > non-trivial system resources and additional tools. >=20 > Maybe coming up with a way of extending the C grammar in some more > general way, and then submitting the changes to the tree-sitter-c > developers for inclusion would be OK. >=20 > But I very much hope that we could support these macros at a lower > cost, by some tailored Lisp. Please give it a try. Even if the > result works only for the cases we actually use in our sources, it > might be "good enough" for us. Fair enough, I=E2=80=99ll try :-) Yuan=