From: "Nicolas Léveillé" <nicolas@uucidl.com>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 17519@debbugs.gnu.org
Subject: bug#17519: [PATCH] take into account QuantumScale when reading imagemagick images
Date: Tue, 20 May 2014 09:37:17 +0200 [thread overview]
Message-ID: <C0A7F531-4478-40D5-B05A-1AB6A711C16A@uucidl.com> (raw)
In-Reply-To: <537A63BC.5090408@cs.ucla.edu>
I'll come back to you once I'll have tested your patch.
Do you object with the other cleanups or is it poor form in this project to clean up code while fixing a bug? (Not sure what the philosophy in this project is, I tend to alway opportunistically do a little clean up (in separate commits/patches) when I fix bugs as a form of low intensity maintenance work)
Cheers,
Nicolas
On 2014-05-19, at 22:04 , Paul Eggert <eggert@cs.ucla.edu> wrote:
> Thanks for reporting this. Does the attached simpler patch fix the problem for you? Dividing by QuantumRange instead of multiplying by QuantumScale avoids potential double-rounding problems in future versions of ImageMagick.
> <imagemagick.patch>
next prev parent reply other threads:[~2014-05-20 7:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-17 13:25 bug#17519: [PATCH] take into account QuantumScale when reading imagemagick images Nicolas Léveillé
2014-05-19 20:04 ` Paul Eggert
2014-05-20 7:37 ` Nicolas Léveillé [this message]
2014-05-20 8:07 ` Paul Eggert
2014-05-21 19:31 ` Nicolas Léveillé
2014-05-21 19:54 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C0A7F531-4478-40D5-B05A-1AB6A711C16A@uucidl.com \
--to=nicolas@uucidl.com \
--cc=17519@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.