From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#68781: [PATCH] Don't fill yaml except comments and block scalars. Date: Tue, 30 Jan 2024 19:25:07 +0000 Message-ID: References: <216ddb7b-e02d-4e68-9dbb-68fa1202d198@mgmarlow.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16688"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Rudolf Schlatte , 68781@debbugs.gnu.org To: Graham Marlow Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 30 20:26:50 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rUtku-00048y-RC for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 30 Jan 2024 20:26:49 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rUtkO-0005A8-3h; Tue, 30 Jan 2024 14:26:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUtk4-00050v-VM for bug-gnu-emacs@gnu.org; Tue, 30 Jan 2024 14:25:58 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rUtk4-0004xz-NG for bug-gnu-emacs@gnu.org; Tue, 30 Jan 2024 14:25:56 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rUtkD-00032L-Ng for bug-gnu-emacs@gnu.org; Tue, 30 Jan 2024 14:26:05 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Jan 2024 19:26:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68781 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68781-submit@debbugs.gnu.org id=B68781.170664273311428 (code B ref 68781); Tue, 30 Jan 2024 19:26:05 +0000 Original-Received: (at 68781) by debbugs.gnu.org; 30 Jan 2024 19:25:33 +0000 Original-Received: from localhost ([127.0.0.1]:36796 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUtjh-0002yF-Ff for submit@debbugs.gnu.org; Tue, 30 Jan 2024 14:25:33 -0500 Original-Received: from mail-4323.proton.ch ([185.70.43.23]:50399) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUtje-0002xv-TS for 68781@debbugs.gnu.org; Tue, 30 Jan 2024 14:25:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail; t=1706642714; x=1706901914; bh=MnvGiMkJj6KQIB2F4BHG5k9UNdGdEn5uUu66hvOrM+I=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=ES+i4vU9bObgoGSvHuVjKmqR0/A7lh46FkS1hwZKjopgj9yMP1f9n98DJaCvXm+3/ LIALDIlOJbZGnS0RpZbkClnpEG97loJow+bcoWjuN1olGeSWfZngZKVnkpeFG0QaS8 4EtxaTfVHwjXMOYv/Aq/L8tYJ0QOVU5uVREtKwvkflEO5a1QUfamLEQnCSoYksdsho qZ4p+FnigwrpLUHPSFtAaPrIxDYryezmpezlqfbMngudmG8lKhgpZoZYi2wHfCyYrI eEaPkrUVtmhPm90m2XnuRVD40IgdG61pQuYPW+7M6N+Zje2wcCfMnORnjljmr8kyAl PiO5O9dXOmtmw== In-Reply-To: <216ddb7b-e02d-4e68-9dbb-68fa1202d198@mgmarlow.com> Feedback-ID: 44397038:user:proton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279200 Archived-At: On Monday, January 29th, 2024 at 20:20, Graham Marlow = wrote: >=20 >=20 > > Hello Randy, thanks for having a look! Could you tell me which >=20 > > tree-sitter grammar you are using? I'm asking because with the grammar > > from https://github.com/ikatyang/tree-sitter-yaml I don't see what you > > describe. >=20 >=20 > For the record I'm also using this grammar. >=20 > Looking at the patch, what do you think about retaining the existing > behavior (so block_scalars still fill correctly) while inhibiting > fill_paragraph for everything else as suggested? Originally I retained > the existing behavior of fill-paragraph just to limit the number of > things changed by the patch, not because it was working properly. I > think blocking the call to fill-paragraph for non-block/comment nodes > makes sense. >=20 > I attached a patch w/ my edits, but it just swaps the when to and if, > accepts the comment node type for filling, and returns t to avoid > calling fill-paragraph for other nodes. Thanks Graham, the patch looks good to me. Would someone please install it on master? Thanks in advance.