From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#59833: 29.0.60; json-ts-mode fontifies everything as string Date: Mon, 05 Dec 2022 14:42:37 +0000 Message-ID: References: <87sfhudrfu.fsf@thornhill.no> <_KSXcXGtjgQ4mzy-Ml9kIV0QngRcfhNomsCAtEhd7ZAP6ih86_WavpD-qSNN-MnXBLi0VACZ57_Ig4MkuoD5FB5qk80Y7C-LYaZrZRvSdK8=@rjt.dev> <4pslNusoayXbQq867kk1hbmFpD9rInmrKFngvhWbFFEFg-V1SrZLqJ47TyJDGrFal86hf7cLAGAD_KiCUyCEh52J45_tu4wAQ9HXpkIiFzI=@rjt.dev> <87sfhuvt0h.fsf@thornhill.no> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15028"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Yuan Fu , 59833@debbugs.gnu.org, jostein@kjonigsen.net To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 05 15:43:45 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p2Ch6-0003g1-LY for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Dec 2022 15:43:44 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p2CgS-0004ZI-Nl; Mon, 05 Dec 2022 09:43:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2CgR-0004Yd-9M for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 09:43:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p2CgQ-0000Rp-SU for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 09:43:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p2CgQ-0003rv-Of for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 09:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Dec 2022 14:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59833 X-GNU-PR-Package: emacs Original-Received: via spool by 59833-submit@debbugs.gnu.org id=B59833.167025137314858 (code B ref 59833); Mon, 05 Dec 2022 14:43:02 +0000 Original-Received: (at 59833) by debbugs.gnu.org; 5 Dec 2022 14:42:53 +0000 Original-Received: from localhost ([127.0.0.1]:36396 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2CgG-0003ra-VC for submit@debbugs.gnu.org; Mon, 05 Dec 2022 09:42:53 -0500 Original-Received: from mail-4317.proton.ch ([185.70.43.17]:21439) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2CgD-0003rT-Ki for 59833@debbugs.gnu.org; Mon, 05 Dec 2022 09:42:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1670251362; x=1670510562; bh=yYHZcR7iXXD9mTGXofjldLNoWAefIxLHFH/uo0FeyXI=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=BWqi7/XGzZQ5ItO9AlpxKgeE3qpzyCqwZgvnpqRnWRztn4frIjp1rnNJKmVADW++p TYyGcgmruqzffZhc6cp6eqBuQ44EB43HZ58E864j3uAjoD/6ZMgfzeXRR/ZoRy52hn c7+Z82oLZXTaQHY+Cl0Y2naxcg9TESDnJARphFVjDnYgieDQSU1j9pXtNbfN/bmx6g C1G1/snmC9BTPeQPqoxyi1wrW5E4Qdtviyi25BXBtqXA74FvP7f7NrLtwvJBBys1Rx sxThvxzeucHtG5uBvLZ6o28qb0qoMMkBZuzScwMHDyXe+uigrlZRjMmftKlUvxtSzk eNkSjBbJqyzAQ== In-Reply-To: <87sfhuvt0h.fsf@thornhill.no> Feedback-ID: 44397038:user:proton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250032 Archived-At: On Monday, December 5th, 2022 at 09:12, Theodor Thornhill wrote: >=20 >=20 > Randy Taylor dev@rjt.dev writes: >=20 > > On Monday, December 5th, 2022 at 08:52, Randy Taylor dev@rjt.dev wrote: > >=20 > > > On Monday, December 5th, 2022 at 06:24, Theodor Thornhill theo@thornh= ill.no wrote: > > >=20 > > > > Jostein Kj=C3=B8nigsen jostein@secure.kjonigsen.net writes: > > > >=20 > > > > > Hey everyone. > > > > >=20 > > > > > When opening a JSON-file in a build from emacs git emacs-29 > > > > > release-branch, Emacs still defaults to json-mode. > > > > >=20 > > > > > Fontification in json-mode looks correct and proper. > > > > >=20 > > > > > When trying to insteas use json-ts-mode, literally everything is > > > > > fontified as strings. > > > > >=20 > > > > > When I change the code to disable the string-fontification rule, = this > > > > > yields a buffer where everything is fontified using default-face.= That > > > > > is, no other fontification is taking place. > > > > >=20 > > > > > Have this mode really been tested? Should it be working? Or is th= ere an > > > > > error on my end? > > > > >=20 > > > > > Could someone else please give json-ts-mode a try? > > > >=20 > > > > Yeah, you are correct. It seems we've had a regression in this comm= it, > > > > 0ed313642227afdeccf48057eea458edca9d2962. > > > >=20 > > > > I believe this is the offending commit - what do you think, Randy? > > > >=20 > > > > Specifically the lhs should be fontified differently than the rhs, = so > > > > not everything is a string. > > > >=20 > > > > Do you want to do that, Randy, or should I? > > > >=20 > > > > Theo > > >=20 > > > Can someone show me an example JSON file that shows this problem? Eve= rything looks the same for me in json-mode and json-ts-mode, except for the= json-ts-mode extras (even with Theo's patch) both with my own Emacs config= and emacs -Q. I must be doing something very silly. > >=20 > > Scratch that, I got Theo's patch working, needed to rebuild. >=20 >=20 > No need to rebuild. Just C-M-x the defvar and revert buffer. I was even restarting and it wasn't picking up the changes for some reason. >=20 > > Looks good to me (although it would be nice to keep treesit-font-lock-f= eature-list alphabetized Theo ;)). >=20 >=20 > See new patch! Thanks, I meant just the treesit-font-lock-feature-list variable :) (so mov= ing pair before string). Having the font-lock settings alphabetized too is great, but I remember run= ning into some highlighting issues depending on the order of things. For example, since error is above number, the number face will not be highl= ighted as error when an error occurs. Try: { "test": 2 } and remove the colon. Before your patch, the entire line is red. After, onl= y "test" is red. So in general, I think we should stick all :overrides at the bottom of that= list (with error being the ultimate one), and keep everything above and be= low alphabetized, but separately, which is how I organized json-ts-mode. >=20 > > json-mode still fontifies pretty much everything as a string though (at= least for me). >=20 >=20 > Not for me. I get number-face, bracket-face, constant-face, > warning-face. Don't you? Are you guys talking about the json-mode package? Jostein mentioned "Emacs = still defaults to json-mode", but when I open a JSON file I get js-json-mod= e, which is what I assumed he meant. js-json-mode is what I was trying to m= atch in json-ts-mode. >=20 > Will you commit this, Yuan? >=20 > Theo