From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.devel Subject: RE: bug of display-table & make-glyph-code Date: Mon, 10 Sep 2007 18:24:33 -0700 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1189476358 31063 80.91.229.12 (11 Sep 2007 02:05:58 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 11 Sep 2007 02:05:58 +0000 (UTC) Cc: emacs-devel@gnu.org To: "Kenichi Handa" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 11 12:05:45 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IV1z4-0005S9-J5 for ged-emacs-devel@m.gmane.org; Tue, 11 Sep 2007 11:24:38 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IUuUh-0002dD-KP for ged-emacs-devel@m.gmane.org; Mon, 10 Sep 2007 21:24:47 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IUuUd-0002Z9-U0 for emacs-devel@gnu.org; Mon, 10 Sep 2007 21:24:43 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IUuUd-0002Xn-9U for emacs-devel@gnu.org; Mon, 10 Sep 2007 21:24:43 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IUuUd-0002XL-1Z for emacs-devel@gnu.org; Mon, 10 Sep 2007 21:24:43 -0400 Original-Received: from rgminet01.oracle.com ([148.87.113.118]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IUuUc-0004jk-OJ for emacs-devel@gnu.org; Mon, 10 Sep 2007 21:24:42 -0400 Original-Received: from agmgw1.us.oracle.com (agmgw1.us.oracle.com [152.68.180.212]) by rgminet01.oracle.com (Switch-3.2.4/Switch-3.1.6) with ESMTP id l8B1ObMH007645; Mon, 10 Sep 2007 19:24:37 -0600 Original-Received: from acsmt350.oracle.com (acsmt350.oracle.com [141.146.40.150]) by agmgw1.us.oracle.com (Switch-3.2.0/Switch-3.2.0) with ESMTP id l89H9PjV029963; Mon, 10 Sep 2007 19:24:35 -0600 Original-Received: from dhcp-amer-csvpn-gw1-141-144-64-225.vpn.oracle.com by acsmt350.oracle.com with ESMTP id 3200838521189473872; Mon, 10 Sep 2007 18:24:32 -0700 X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook IMO, Build 9.0.6604 (9.0.2911.0) Importance: Normal In-Reply-To: X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3138 X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE X-Detected-Kernel: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:78547 Archived-At: > > However, I do use what is essentially Kim's `make-glyph-code' (which I > > thought was going to be added to Emacs for version 23), so I > hope glyphs are > > not being removed altogether. (I use `make-glyph-code' to provide > > replacement text for "^L" for inserted form-feed chars.) > > I don't intend to delete the concept of "glyph". I'm just > going to change the Lispy representation of "glyph" from > integer to something like (CHAR . FACE-ID). But if we do > that, we can't keep backward compatibility about > glyph-table. So I suggest to delete it if not that useful > now. Hmm. It sounds like that change would necessitate a change to Kim's function. Since I use his definition without really understanding it ;-), I would appreciate a version that will work after your changes. And I'd like to know what I can test in my code to know which version to use (for use with different Emacs versions). Here is the definition I am using now (Emacs 22.1): (defun make-glyph-code (char &optional face) "Return a glyph code representing char CHAR with face FACE." (if face (logior char (lsh (face-id face) (if (<= emacs-major-version 22) 19 22))) char)) Thanks.