all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: "martin rudalics" <rudalics@gmx.at>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
	Emacs-Devel <emacs-devel@gnu.org>
Subject: RE: toggling a minor mode should not tell Customize that the value has been set
Date: Sun, 6 Jan 2008 15:41:13 -0800	[thread overview]
Message-ID: <BNELLINCGFJLDJIKDGACGEHHCGAA.drew.adams@oracle.com> (raw)
In-Reply-To: <4781590A.4090108@gmx.at>

>  > Putting `customize-customized' on `kill-emacs-query-functions'
>  > is analogous to Emacs telling you that you have unsaved modified
>  > buffers, and asking if you want to quit anyway and lose your
>  > changes. Toggling a mode variable is not an act of customization;
>  > there is no loss if you exit without saving the latest value.
>
> There is.  Suppose you have done "set for current session only" and some
> action changes this to "CHANGED outside Customize; operating on it here
> may be unreliable".  When you now exit Emacs you will _not_ get warned
> that you have unsaved customizations.

Fair enough. Would you then change all commands that change option values so
that they too tell Customize that the value has been customized? Would you
somehow make sure that not only commands but all Lisp code does the same
thing?

If not, then the problem you raise remains for every option other than a
minor-mode variable. No - it remains even for a minor-mode variable, except
when it is toggled via its mode command.

What is special about toggling a minor mode in this respect? Why is it an
exception? That is the question.

Making a minor-mode toggle command do this does not take care of the general
issue you raise, in any case. And if a user is really worried about the
scenario you raise, then s?he can use `customize-rogue' instead of
`customize-customized' in the hook.

  reply	other threads:[~2008-01-06 23:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-05 17:48 toggling a minor mode should not tell Customize that the value has been set Drew Adams
2008-01-06  2:14 ` Stefan Monnier
2008-01-06  8:01   ` Drew Adams
2008-01-06 16:16     ` Stefan Monnier
2008-01-06 20:47       ` Drew Adams
2008-01-06 21:20         ` Stefan Monnier
2008-01-06 23:00           ` Drew Adams
2008-01-07  1:32             ` Stefan Monnier
2008-01-06 22:41         ` martin rudalics
2008-01-06 23:41           ` Drew Adams [this message]
2008-01-07  1:26             ` Stefan Monnier
2008-01-07  7:34             ` martin rudalics
2008-01-07 11:31             ` Richard Stallman
2008-01-06 10:46 ` Richard Stallman
2008-01-06 16:19   ` toggling a minor mode should not tell Customize that the value hasbeen set Drew Adams
2008-01-07 17:15     ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BNELLINCGFJLDJIKDGACGEHHCGAA.drew.adams@oracle.com \
    --to=drew.adams@oracle.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.