From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.devel Subject: RE: doc-view support for bookmark.el Date: Tue, 25 Dec 2007 09:24:09 -0800 Message-ID: References: <8763yn3v07.fsf@member.fsf.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1198603455 16517 80.91.229.12 (25 Dec 2007 17:24:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 25 Dec 2007 17:24:15 +0000 (UTC) To: "Tassilo Horn" , Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 25 18:24:27 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1J7DVw-0003K2-4i for ged-emacs-devel@m.gmane.org; Tue, 25 Dec 2007 18:24:24 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J7DVb-00052K-Im for ged-emacs-devel@m.gmane.org; Tue, 25 Dec 2007 12:24:03 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J7DVZ-00052F-5U for emacs-devel@gnu.org; Tue, 25 Dec 2007 12:24:01 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J7DVW-00050g-LT for emacs-devel@gnu.org; Tue, 25 Dec 2007 12:23:59 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J7DVW-00050Y-FF for emacs-devel@gnu.org; Tue, 25 Dec 2007 12:23:58 -0500 Original-Received: from rgminet01.oracle.com ([148.87.113.118]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1J7DVW-0007Cj-6g for emacs-devel@gnu.org; Tue, 25 Dec 2007 12:23:58 -0500 Original-Received: from agmgw1.us.oracle.com (agmgw1.us.oracle.com [152.68.180.212]) by rgminet01.oracle.com (Switch-3.2.4/Switch-3.1.6) with ESMTP id lBPHNqgA027340; Tue, 25 Dec 2007 10:23:53 -0700 Original-Received: from acsmt350.oracle.com (acsmt350.oracle.com [141.146.40.150]) by agmgw1.us.oracle.com (Switch-3.2.0/Switch-3.2.0) with ESMTP id lBPEO3ka017231; Tue, 25 Dec 2007 10:23:52 -0700 Original-Received: from dhcp-amer-csvpn-gw1-141-144-64-13.vpn.oracle.com by acsmt350.oracle.com with ESMTP id 3463269191198603422; Tue, 25 Dec 2007 09:23:42 -0800 X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook IMO, Build 9.0.6604 (9.0.2911.0) In-Reply-To: <8763yn3v07.fsf@member.fsf.org> Importance: Normal X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3198 X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:85448 Archived-At: > When I was doing that I found some strange code: bookmark-jump-noselect > opened the bookmarked file, set point at the correct position and > returned a cons (BUFFER . POSITION). All calling functions did set the > position once again. I suspect that was a relict of the past, so I > removed it and now bookmark-jump-noselect only returns the buffer. `bookmark-jump' expects the return value of `bookmark-jump-noselect' to be what it has always been, a "cell" that provides both the buffer and the position. I define my own `bookmark-jump-other-window' analogously, so it has the same expectation: (defun bookmark-jump-other-window (bookmark) "Jump to BOOKMARK (a point in some file) in another window. See `bookmark-jump'." (interactive (list (bookmark-completing-read "Jump to bookmark (in another window)" bookmark-current-bookmark))) (when bookmark (bookmark-maybe-historicize-string bookmark) (let ((cell (bookmark-jump-noselect bookmark))) (and cell (switch-to-buffer-other-window (car cell)) (goto-char (cdr cell)) (if bookmark-automatically-show-annotations ;; if there is an annotation for this bookmark, ;; show it in a buffer. (bookmark-show-annotation bookmark)))))) > Till now I didn't use bookmarks, so I'm not sure if this change will > break something. See above.