From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.devel Subject: RE: New keybinding suggestion: C-x _ for `shrink-window' Date: Sun, 11 Nov 2007 18:55:01 -0800 Message-ID: References: <87sl3cm9p5.fsf@bzg.ath.cx> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1194836213 18792 80.91.229.12 (12 Nov 2007 02:56:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 12 Nov 2007 02:56:53 +0000 (UTC) Cc: rms@gnu.org, emacs-devel@gnu.org To: "Bastien" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 12 03:56:56 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IrPTr-0002i6-3U for ged-emacs-devel@m.gmane.org; Mon, 12 Nov 2007 03:56:55 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IrPTe-0000aI-IR for ged-emacs-devel@m.gmane.org; Sun, 11 Nov 2007 21:56:42 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IrPTa-0000a5-5z for emacs-devel@gnu.org; Sun, 11 Nov 2007 21:56:38 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IrPTY-0000Zj-Im for emacs-devel@gnu.org; Sun, 11 Nov 2007 21:56:37 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IrPTY-0000Zg-D0 for emacs-devel@gnu.org; Sun, 11 Nov 2007 21:56:36 -0500 Original-Received: from rgminet01.oracle.com ([148.87.113.118]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IrPTU-0005WV-0f; Sun, 11 Nov 2007 21:56:32 -0500 Original-Received: from rgmgw1.us.oracle.com (rgmgw1.us.oracle.com [138.1.186.110]) by rgminet01.oracle.com (Switch-3.2.4/Switch-3.1.6) with ESMTP id lAC2uQO9024537; Sun, 11 Nov 2007 19:56:26 -0700 Original-Received: from acsmt351.oracle.com (acsmt351.oracle.com [141.146.40.151]) by rgmgw1.us.oracle.com (Switch-3.2.4/Switch-3.2.4) with ESMTP id lAC2sadM015490; Sun, 11 Nov 2007 19:56:25 -0700 Original-Received: from dhcp-amer-whq-csvpn-gw3-141-144-80-223.vpn.oracle.com by acsmt351.oracle.com with ESMTP id 3359485851194836090; Sun, 11 Nov 2007 18:54:50 -0800 X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook IMO, Build 9.0.6604 (9.0.2911.0) In-Reply-To: <87sl3cm9p5.fsf@bzg.ath.cx> Importance: Normal X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3198 X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:83011 Archived-At: > The last version do this: when pop-up-frames is `nil' don't exit the > loop. When pop-up-frames is `t', exit the loop. Is that ok? Yes. Sorry, I was looking at the previous version. Looks good. However, there is a new bug (at least in Emacs 22.1.1): `q' in *Help* no longer quits help-mode. This is likely a `help-mode' or a `view-mode' bug, not a bug in your code - `q' in `help-mode' is notorious for not doing the right thing. At least with `pop-up-frames' non-nil and your code, `q' in *Help* does nothing at all. Martin was working on similar `View-quit' bugs; I don't know if this one is fixed in CVS. Perhaps someone with the latest Emacs can test this using window-edit.el and non-nil `pop-up-frames'. BTW, byte-compiling window-edit.el gives this warning: window-edit.el:219:22:Warning: variable assignment to nonvariable `""' The line in question is this: (ring-insert-at-beginning window-configuration-ring wcf0) Anyone have an idea what this is about? The message doesn't seem too helpful.