From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.devel Subject: RE: display-completion-list should not strip text properties Date: Wed, 5 Sep 2007 07:21:12 -0700 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1189002163 592 80.91.229.12 (5 Sep 2007 14:22:43 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 5 Sep 2007 14:22:43 +0000 (UTC) To: Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 05 16:22:42 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1ISvm5-0003eb-Q0 for ged-emacs-devel@m.gmane.org; Wed, 05 Sep 2007 16:22:34 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ISvm3-0004GA-DY for ged-emacs-devel@m.gmane.org; Wed, 05 Sep 2007 10:22:31 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ISvm0-0004Du-2v for emacs-devel@gnu.org; Wed, 05 Sep 2007 10:22:28 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ISvlv-00048H-1d for emacs-devel@gnu.org; Wed, 05 Sep 2007 10:22:27 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ISvlu-00048E-St for emacs-devel@gnu.org; Wed, 05 Sep 2007 10:22:22 -0400 Original-Received: from rgminet01.oracle.com ([148.87.113.118]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1ISvlu-0005Xn-Hr for emacs-devel@gnu.org; Wed, 05 Sep 2007 10:22:22 -0400 Original-Received: from agmgw2.us.oracle.com (agmgw2.us.oracle.com [152.68.180.213]) by rgminet01.oracle.com (Switch-3.2.4/Switch-3.1.6) with ESMTP id l85EMHVk011361 for ; Wed, 5 Sep 2007 08:22:17 -0600 Original-Received: from acsmt350.oracle.com (acsmt350.oracle.com [141.146.40.150]) by agmgw2.us.oracle.com (Switch-3.2.0/Switch-3.2.0) with ESMTP id l8446Nrs008017 for ; Wed, 5 Sep 2007 08:22:17 -0600 Original-Received: from dhcp-amer-csvpn-gw1-141-144-64-152.vpn.oracle.com by acsmt350.oracle.com with ESMTP id 3184311071189002070; Wed, 05 Sep 2007 07:21:10 -0700 X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook IMO, Build 9.0.6604 (9.0.2911.0) Importance: Normal In-Reply-To: X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3138 X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE X-MIME-Autoconverted: from 8bit to quoted-printable by rgminet01.oracle.com id l85EMHVk011361 X-Detected-Kernel: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:77860 Archived-At: > I'd extend this \# syntax to support other text properties by havin= g > \#(prop value ...) text# mean (propertize "text" 'prop 'value '...)= , > and of course have \#value text# imply \#(highlight value) text#. > > Why do we need to put properties other that the `face' property > in doc strings? There are already ways to make links. To include graphics in Help, for one thing. Johan makes that point in his mail quoted below. > 1. Let's accept Johan's fix for `describe-variable'. > > Please send this fix again -- I don't remember it. Le voici : > From: Johan "Bockg=E5rd" Sent: Wednesday, January 24, 2007 3:43 PM > Subject: Re: display-completion-list should not strip text properties > > Richard Stallman writes: > > > I agree that this is a good change, and since it is simple and safe, > > we can do it now. > > Here's a related, simple, change that I've been sitting on for a long > time. By putting text properties on doc strings you can insert images > and other fancy stuff in the *Help* buffer. This change makes > describe-variable preserve text properties (describe-function already > does so): > > 2007-01-24 Johan Bockg=E5rd > > * help-fns.el (describe-variable): Keep doc's text properti= es. > > Index: lisp/help-fns.el > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /cvsroot/emacs/emacs/lisp/help-fns.el,v > retrieving revision 1.96 > diff -u -r1.96 help-fns.el > --- lisp/help-fns.el 23 Jan 2007 07:16:11 -0000 1.96 > +++ lisp/help-fns.el 24 Jan 2007 23:15:35 -0000 > @@ -596,7 +596,8 @@ > "which is byte-compiled expression.\n" > (format "`%s'.\n" safe-var)))) > (princ "\nDocumentation:\n") > - (princ (or doc "Not documented as a variable."))) > + (with-current-buffer standard-output > + (insert (or doc "Not documented as a variable.")))) > ;; Make a link to customize if this variable can be customized. > (if (custom-variable-p variable) > (let ((customize-label "customize"))