From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Adrian Robert Newsgroups: gmane.emacs.devel Subject: Re: #defines and MacOS X Date: Fri, 28 Oct 2005 11:22:24 -0400 Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 (Apple Message framework v734) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1130514749 4781 80.91.229.2 (28 Oct 2005 15:52:29 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 28 Oct 2005 15:52:29 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 28 17:52:27 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EVWTE-0003Oc-5g for ged-emacs-devel@m.gmane.org; Fri, 28 Oct 2005 17:48:44 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EVWTA-0000jS-Qz for ged-emacs-devel@m.gmane.org; Fri, 28 Oct 2005 11:48:40 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EVW3t-0002xr-Ti for emacs-devel@gnu.org; Fri, 28 Oct 2005 11:22:34 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EVW3r-0002wZ-LO for emacs-devel@gnu.org; Fri, 28 Oct 2005 11:22:33 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EVW3r-0002wH-EX for emacs-devel@gnu.org; Fri, 28 Oct 2005 11:22:31 -0400 Original-Received: from [140.251.1.25] (helo=smtp-in1.med.cornell.edu) by monty-python.gnu.org with esmtp (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA:24) (Exim 4.34) id 1EVW3m-0007Af-W5 for emacs-devel@gnu.org; Fri, 28 Oct 2005 11:22:31 -0400 Original-Received: from mpx1.med.cornell.edu (biglb-vlan511vip.med.cornell.edu [140.251.11.120]) by smtp-in1.med.cornell.edu (Switch-3.1.6/Switch-3.1.6) with ESMTP id j9SFMP1p222050 for ; Fri, 28 Oct 2005 11:22:25 -0400 Original-Received: from [140.251.33.115] by mpx1.med.cornell.edu (Sun Java System Messaging Server 6.1 HotFix 0.11 (built Jan 28 2005)) with ESMTP id <0IP200DLKTDCGI10@mpx1.med.cornell.edu> for emacs-devel@gnu.org; Fri, 28 Oct 2005 11:22:24 -0400 (EDT) In-reply-to: Original-To: "Kim F. Storm" X-Mailer: Apple Mail (2.734) X-PMX-Version: 4.7.1.128075, Antispam-Engine: 2.1.0.0, Antispam-Data: 2005.10.28.15 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:45033 Archived-At: On Oct 28, 2005, at 4:36 AM, Kim F. Storm wrote: > Adrian Robert writes: > > >> Meanwhile, I already updated the Nextstep port to avoid this problem >> using: >> >> HAVE_NS >> GNUSTEP >> COCOA >> > > These should at least include MAC_ somewhere to > indicate that they are specific to the MAC port, e.g > > HAVE_MAC_NEXTSTEP > MAC_GNUSTEP > MAC_COCOA Well, it's not "Mac" specific, since the same port runs on GNUstep (on linux, FreeBSD, eventually Windows, etc.). The common denominator is the API, much like using Xlib on different OS's. I thought briefly about: HAVE_NS NS_GNUSTEP NS_COCOA But then thought both GNUSTEP and COCOA were fairly clear in their own right. The symbol 'ns' is used elsewhere for the port, as in window-system 'ns, 'ns-win.el', etc.. I realize it may look a little short and cryptic, but given these are developer-visible strings, and every class and function name in the API starts with the letters "NS", it seems fairly clear. Maybe another idea would be: HAVE_NEXTSTEP (or perhaps HAVE_OPENSTEP) NEXTSTEP_GNU NEXTSTEP_MAC Or HAVE_NEXTSTEP / NS_GNUSTEP / NS_COCOA... >> Whatever is agreed upon, I'm willing to generate the patches for both >> HEAD and the unicode-2 branch. >> > > Others will have to decide whether it is ok to do so now. > > Personally, I think it should wait until after releasing 22.x -- also > on the unicode-2 branch to ease merging of patches between the > branches. I'm fine with this. Especially if the Mac maintainers think that some logic (as opposed to just names) might change as a result, it's best to wait post-release.