From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#12507: 24.2.50; `bookmark-write-file': use `write-file', not `write-region', to get backups Date: Mon, 24 Sep 2012 11:41:39 -0700 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1348512135 7372 80.91.229.3 (24 Sep 2012 18:42:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 24 Sep 2012 18:42:15 +0000 (UTC) To: 12507@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 24 20:42:20 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TGDbn-0005Rs-Sm for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Sep 2012 20:42:20 +0200 Original-Received: from localhost ([::1]:57223 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGDbj-0007B5-4D for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Sep 2012 14:42:15 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:48825) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGDbf-0007Ap-NK for bug-gnu-emacs@gnu.org; Mon, 24 Sep 2012 14:42:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TGDbb-0002Vg-At for bug-gnu-emacs@gnu.org; Mon, 24 Sep 2012 14:42:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44031) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGDbb-0002Vb-7B for bug-gnu-emacs@gnu.org; Mon, 24 Sep 2012 14:42:07 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TGDdS-0007sS-09 for bug-gnu-emacs@gnu.org; Mon, 24 Sep 2012 14:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Sep 2012 18:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 12507 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: Original-Received: via spool by submit@debbugs.gnu.org id=B.134851224030263 (code B ref -1); Mon, 24 Sep 2012 18:44:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 24 Sep 2012 18:44:00 +0000 Original-Received: from localhost ([127.0.0.1]:53577 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TGDdP-0007s4-OC for submit@debbugs.gnu.org; Mon, 24 Sep 2012 14:44:00 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:59135) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TGDdN-0007rv-7X for submit@debbugs.gnu.org; Mon, 24 Sep 2012 14:43:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TGDbV-0002U5-2Q for submit@debbugs.gnu.org; Mon, 24 Sep 2012 14:42:01 -0400 Original-Received: from lists.gnu.org ([208.118.235.17]:38563) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGDbU-0002U1-VC for submit@debbugs.gnu.org; Mon, 24 Sep 2012 14:42:00 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:48741) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGDbT-0007Ag-US for bug-gnu-emacs@gnu.org; Mon, 24 Sep 2012 14:42:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TGDbS-0002TW-Pn for bug-gnu-emacs@gnu.org; Mon, 24 Sep 2012 14:41:59 -0400 Original-Received: from acsinet15.oracle.com ([141.146.126.227]:43189) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGDbS-0002TP-JW for bug-gnu-emacs@gnu.org; Mon, 24 Sep 2012 14:41:58 -0400 Original-Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q8OIftpu019642 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 24 Sep 2012 18:41:56 GMT Original-Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q8OIfsVc025340 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 24 Sep 2012 18:41:54 GMT Original-Received: from abhmt117.oracle.com (abhmt117.oracle.com [141.146.116.69]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q8OIfr3Q008703 for ; Mon, 24 Sep 2012 13:41:53 -0500 Original-Received: from dradamslap1 (/10.159.184.43) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 24 Sep 2012 11:41:53 -0700 X-Mailer: Microsoft Office Outlook 11 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Thread-Index: Ac2ahDvlafFaZnD7TQiYo3vn9G5VoQ== X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:64854 Archived-At: I believe that `bookmark-write-file' should use `write-file', not `write-region', because otherwise no backup file is made for the user's bookmark file. The original code used `write-file'. The change was made to use `write-region' on 2005-11-12: Revision ID: kfogel@red-bean.com-20051112203022-g0v8q4n9urlfew61 (bookmark-write-file): Don't visit the destination file, just write the data to it using write-region. This is similar to revision 1.32 of saveplace.el, but with an additional change to avoid visiting the file in the first place. I'm no expert on this, but from what I see by experimenting, using `write-region' means that no backup is made, and using `write-file' creates a backup. It is important for users to be able to have a backup for their bookmark file. In GNU Emacs 24.2.50.1 (i386-mingw-nt5.1.2600) of 2012-09-17 on MARVIN Bzr revision: 110062 cyd@gnu.org-20120917054104-r93rtwkrtva73ewe Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --with-gcc (4.7) --no-opt --enable-checking --cflags -ID:/devel/emacs/libs/libXpm-3.5.8/include -ID:/devel/emacs/libs/libXpm-3.5.8/src -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include -ID:/devel/emacs/libs/giflib-4.1.4-1/include -ID:/devel/emacs/libs/jpeg-6b-4/include -ID:/devel/emacs/libs/tiff-3.8.2-1/include -ID:/devel/emacs/libs/gnutls-3.0.9/include -ID:/devel/emacs/libs/libiconv-1.13.1-1-dev/include -ID:/devel/emacs/libs/libxml2-2.7.8/include/libxml2'