all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: 12507@debbugs.gnu.org
Subject: bug#12507: 24.2.50; `bookmark-write-file': use `write-file', not `write-region', to get backups
Date: Mon, 24 Sep 2012 11:41:39 -0700	[thread overview]
Message-ID: <BDD7F25830C241E284E0F25D820A1991@us.oracle.com> (raw)

I believe that `bookmark-write-file' should use `write-file', not
`write-region', because otherwise no backup file is made for the user's
bookmark file.
 
The original code used `write-file'.  The change was made to use
`write-region' on 2005-11-12:
 
 Revision ID: kfogel@red-bean.com-20051112203022-g0v8q4n9urlfew61
 
 (bookmark-write-file): Don't visit the destination file, just write
 the data to it using write-region.  This is similar to revision 1.32
 of saveplace.el, but with an additional change to avoid visiting the
 file in the first place.
 
I'm no expert on this, but from what I see by experimenting, using
`write-region' means that no backup is made, and using `write-file'
creates a backup.  It is important for users to be able to have a backup
for their bookmark file.
 
 
In GNU Emacs 24.2.50.1 (i386-mingw-nt5.1.2600)
 of 2012-09-17 on MARVIN
Bzr revision: 110062 cyd@gnu.org-20120917054104-r93rtwkrtva73ewe
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
 `configure --with-gcc (4.7) --no-opt --enable-checking --cflags
 -ID:/devel/emacs/libs/libXpm-3.5.8/include
 -ID:/devel/emacs/libs/libXpm-3.5.8/src
 -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include
 -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include
 -ID:/devel/emacs/libs/giflib-4.1.4-1/include
 -ID:/devel/emacs/libs/jpeg-6b-4/include
 -ID:/devel/emacs/libs/tiff-3.8.2-1/include
 -ID:/devel/emacs/libs/gnutls-3.0.9/include
 -ID:/devel/emacs/libs/libiconv-1.13.1-1-dev/include
 -ID:/devel/emacs/libs/libxml2-2.7.8/include/libxml2'
 






         reply	other threads:[~2012-09-24 18:41 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87bogubqjy.fsf@gnu.org>
     [not found] ` <handler.s.C.13485522721217.transcript@debbugs.gnu.org>
2012-09-25 13:53   ` bug#12507: [debbugs-tracker] Processed: severity 12507 wishlist Drew Adams
2012-09-26  2:53     ` Chong Yidong
2012-09-26  3:18       ` Drew Adams
2012-09-26  4:04         ` Stefan Monnier
2012-09-26 14:19           ` Drew Adams
2012-09-26 19:46             ` Stefan Monnier
2012-09-26 20:31               ` Drew Adams
2012-09-26 21:46         ` Karl Fogel
2012-09-26 22:26           ` Drew Adams
2012-09-26 23:36             ` Drew Adams
2012-09-27 15:48             ` Karl Fogel
2012-09-27 16:00               ` Drew Adams
2012-09-27 17:57                 ` Karl Fogel
2012-09-27 18:32                   ` Drew Adams
2012-09-27  3:24           ` Stefan Monnier
2012-09-24 18:41             ` Drew Adams [this message]
2012-09-27  5:38               ` Thierry Volpiatto
2012-09-27 18:37                 ` Drew Adams
2012-09-27 21:16                   ` Thierry Volpiatto
2012-09-28  9:04                   ` Thierry Volpiatto
2012-09-28 20:00                     ` Drew Adams
2012-09-29  7:42               ` Thierry Volpiatto
2012-09-29 14:36                 ` Drew Adams
2012-09-29 15:12                   ` Thierry Volpiatto
2012-09-29 15:51                     ` Drew Adams
2012-09-29 16:20               ` Thierry Volpiatto
2012-09-29 16:50                 ` Drew Adams
2012-09-29 16:57                   ` Thierry Volpiatto
2012-10-01  3:38               ` bug#12507: Option `(bookmark-)version-control': Use :tag so doc string matches menu Karl Fogel
2012-10-01  4:06                 ` bug#12507: Option `(bookmark-)version-control': Use :tag so docstring " Drew Adams
2012-10-01  4:13               ` bug#12507: Have I mentioned how much I hate Debbugs? Karl Fogel
2012-10-01  4:50                 ` Drew Adams
2012-10-01 21:23                   ` Karl Fogel
2012-10-01 22:00                     ` Drew Adams
2012-10-02  5:31                       ` Thierry Volpiatto
2020-11-29  1:07               ` bug#12507: [debbugs-tracker] Processed: severity 12507 wishlist Karl Fogel
2012-09-27  8:36         ` bug#12507: `bookmark-write-file': use `write-file', not `write-region', to get backups Juri Linkov
2012-09-27 15:02           ` Drew Adams
2020-09-18 15:02       ` bug#12507: [debbugs-tracker] Processed: severity 12507 wishlist Lars Ingebrigtsen
2020-09-18 16:23         ` Drew Adams
2020-09-19 14:18           ` Lars Ingebrigtsen
2020-09-19 17:29             ` Drew Adams
2020-09-23  6:41               ` Karl Fogel
2020-09-23 13:34                 ` Lars Ingebrigtsen
2020-09-23 16:23                   ` Eli Zaretskii
2020-09-24 13:58                     ` Lars Ingebrigtsen
2020-09-29  5:27                       ` Karl Fogel
2020-09-29 14:29                         ` Lars Ingebrigtsen
2020-09-23 14:27                 ` Eli Zaretskii
2020-09-23 18:13                   ` Drew Adams
2020-09-23 18:14                 ` Drew Adams
2020-09-29  5:25                   ` Karl Fogel
2020-09-29 15:45                     ` Drew Adams
2020-11-29  0:28                       ` Karl Fogel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BDD7F25830C241E284E0F25D820A1991@us.oracle.com \
    --to=drew.adams@oracle.com \
    --cc=12507@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.