From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#68559: [PATCH] Improve Python shell completion Date: Thu, 15 Feb 2024 18:21:13 +0100 Message-ID: References: <6BAFD8BF-8F18-4D9F-9DB3-A185AEF2EBCA@gmail.com> <867cj5wuo6.fsf@gnu.org> <865xypwu5e.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3845"; mail-complaints-to="usenet@ciao.gmane.io" Cc: liuhui1610@gmail.com, kobarity@gmail.com, 68559@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 15 18:23:01 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rafRq-0000gn-LP for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Feb 2024 18:22:58 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rafRd-0003mC-HV; Thu, 15 Feb 2024 12:22:45 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rafRc-0003ly-2b for bug-gnu-emacs@gnu.org; Thu, 15 Feb 2024 12:22:44 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rafRb-0006EK-RE for bug-gnu-emacs@gnu.org; Thu, 15 Feb 2024 12:22:43 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rafRu-00076f-8Z for bug-gnu-emacs@gnu.org; Thu, 15 Feb 2024 12:23:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Feb 2024 17:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68559 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68559-submit@debbugs.gnu.org id=B68559.170801776327278 (code B ref 68559); Thu, 15 Feb 2024 17:23:02 +0000 Original-Received: (at 68559) by debbugs.gnu.org; 15 Feb 2024 17:22:43 +0000 Original-Received: from localhost ([127.0.0.1]:56898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rafRa-00075q-RU for submit@debbugs.gnu.org; Thu, 15 Feb 2024 12:22:43 -0500 Original-Received: from mail-lj1-f173.google.com ([209.85.208.173]:53421) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rafRY-00075d-FQ for 68559@debbugs.gnu.org; Thu, 15 Feb 2024 12:22:41 -0500 Original-Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-2d109e7bed2so14719701fa.2 for <68559@debbugs.gnu.org>; Thu, 15 Feb 2024 09:22:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708017675; x=1708622475; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=qd2AkenRHl/qCnvc1Dry8RqOnOaqmc1jBzDTYD99H6s=; b=jUJRa2wb391FzFp6WIFEgysikZQan2lctedM+pYV4a+lg+Gg/uojV+5QAVGelPADCt nMcHe9C8xjQd5tz6qpUJx1DmN7ItKTqNL+hEdVps8vX1GUmpVPNPzjxb8j+Gv9acqRzh QpMw0HGOQcFV23hw4tMk1DbK7r5pqrodAvBhv3864ndxATxtZ28tG/sovw1YKbEo8PFO Y2Q5NxSRf3sWlAT53N4DG8DYz4ZjZqmUhZmfFx0LsE4qxBRyoCh3pXM9DOf8w6+ewCVt JlKIMVSPu+bTbKsukEvq4ZigcNYebVSFpNSTpFUkW8r65fFI7Da8EkvHL3+mwZ9nBHMS zB0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708017675; x=1708622475; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=qd2AkenRHl/qCnvc1Dry8RqOnOaqmc1jBzDTYD99H6s=; b=s/1oIiQ/pS7NWN5aH2BnRxV27nTNx6p58vOvR2R/P7FJ1d2nI8HsR/IJFNflOdCoMp ciyM9nCy1rOTeur4epaJ1b2mUsU7JDio9iYYNNdUPsGkyn9qx6PVjam0F3jLEvVKsjad qANEH3IY4EezL8pMJ0Stm08EEMqzAH9uAxnp/YfkkcOBBMX5Rf2Atpyh4zeGKsNn8ilD eEcticyER3selvKNucZKuwAi2HadxxOBHuBjAV0BLeGjOXklciJTCyv8WT+bBXC1HNvI DwJO3GCvxSpj+DYfUid/IJkHsssgFZH2vSNUmw/Czt7ro1wS7i3RSQLfpcRhchMQLh3b iSHQ== X-Forwarded-Encrypted: i=1; AJvYcCUeym2NN8p/Ky1DaPaDCAAkwJuh68+wuw02eECyRkv0r5y+w63gsBzlaHvF+1BghabjUuF2BJphCj3yEN2GZIbzxI0T8ow= X-Gm-Message-State: AOJu0YzNF2KHg+OuQXZco1RMBOUVW+DjnILZubA4ZxlVllsEajh9fFsQ +ACgwhkViHhH4oIlznG0rWWlMZyOwEwF8sOFdGHRRiTXsRzkDYip X-Google-Smtp-Source: AGHT+IG/I3/XUtazdmyJcg+/pWec6g7r5n7oq0lVT6Nlv2DMUT8UlBFtVucH+hcsTLA0L/kDwNLVAA== X-Received: by 2002:a2e:9d97:0:b0:2d0:e1fc:9ca0 with SMTP id c23-20020a2e9d97000000b002d0e1fc9ca0mr1784484ljj.29.1708017675444; Thu, 15 Feb 2024 09:21:15 -0800 (PST) Original-Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id y8-20020a05651c020800b002d0dec71acfsm357161ljn.132.2024.02.15.09.21.14 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Feb 2024 09:21:15 -0800 (PST) In-Reply-To: <865xypwu5e.fsf@gnu.org> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280067 Archived-At: 15 feb. 2024 kl. 17.48 skrev Eli Zaretskii : > The python-*-completion-at-point-* tests never worked for me, and I > always assumed it was something specific to MS-Windows. But maybe > not. There was no change in the tests that fail for me before and > after the recent changes related to Python. Right, I don't think the Windows port is obscure enough to deserve test = failures either; it's an unnecessary impediment. If it cannot easily be = fixed then it's better to mark them to be skipped on Windows so that you = don't see it every time you run 'make check'. Completion in the Python shell worked on macOS before the change but now = pressing TAB causes the process to hang, so something was clearly broken = by the patch. > all the Python tests that failed for you still pass, with the current > master. So I wonder what is it that causes those failures on your > system. The standard Python installation on macOS uses a libedit-based readline = module and the patch author probably didn't test the changes with that = configuration.