bug#2836: 23.0.92; The bottom of my font (Monaco 10) is cut off on Mac OS X

bug#2836: 23.0.92; The bottom of my font (Monaco 10) is cut off on Mac OS X

[David Caldwell]

[-- Attachment #1: Type: text/plain, Size: 1864 bytes --]

I'm using monaco 10 on my Mac:

(set-default-font
"-apple-monaco-medium-r-normal--10-90-72-72-m-90-mac-roman" t)

This pretest, unlike the last one, has less space between each line.
This is cutting off the bottom of the font. Certain characters, most
notably [, ], {, }, ( and ) don't show their bottom row. The screen also
looks more cluttered because of the closer proximity of the lines which
makes it harder to read (I realize that sounds a bit
princess-and-the-pea-ish of me).

-David


In GNU Emacs 23.0.92.1 (i386-apple-darwin9.6.0, NS apple-appkit-949.43)
 of 2009-03-31 on black.local
Windowing system distributor `Apple', version 10.3.949
configured using `configure  '--with-ns''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: nil
  value of $XMODIFIERS: nil
  locale-coding-system: nil
  default-enable-multibyte-characters: t

Major mode: Emacs-Lisp

Minor modes in effect:
  diff-auto-refine-mode: t
  dir-locals-mode: t
  auto-insert-mode: t
  show-paren-mode: t
  delete-selection-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent messages:
Searching subfile emacs-8...
Searching subfile emacs-2...
Searching subfile emacs-3...
Searching subfile emacs-4...
Searching subfile emacs-5...
Searching subfile emacs-6...
Searching subfile emacs-7...
Searching subfile emacs-8...
Mark saved where search started
Mark set


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 304 bytes --]

bug#2836: Acknowledgement (23.0.92; The bottom of my font (Monaco 10) is cut off on Mac OS X)

[David Caldwell]

I have more info about when this occurred. I make nightly builds of the 
emacs cvs tree (http://porkrind.org/emacs) and so I used them to do a 
binary search and found that this bug seems to have been introduced on 
2009-03-14. My builds happen at midnight and 2009-03-14 works and 
2009-03-15 (and later) do not work.

Hopefully this can help someone figure out where this bug came from.

-David

bug#2836: Acknowledgement (23.0.92; The bottom of my font (Monaco 10) is cut off on Mac OS X)

[David Caldwell]

[-- Attachment #1: Type: text/plain, Size: 698 bytes --]

Ok. I went ahead and tracked it down. The regression was a change to 
src/nsfont.m on 2009-03-14 by davidswelt:

> nsfont.m (nsfont_open): remove ns_expand_space, assume -0.5 i.e. no
> additional spacing, similar to Carbon port.

I've attached a patch that fixes the regression (the bottom line of the 
font being dropped). It puts back expand to 0.5 which seems to be the 
default pre-checkin.

A couple things in this piece of code look a little sketchy. The "shrink" 
variable, for instance, seems to be defined but never used anywhere. 
There's some commented out stuff that's unclear what it was meant for and 
no indication of why one might comment it in or otherwise make use of it.

-David

[-- Attachment #2: font-fix-2009-04-04.patch --]
[-- Type: application/octet-stream, Size: 538 bytes --]

Index: src/nsfont.m
===================================================================
RCS file: /sources/emacs/emacs/src/nsfont.m,v
retrieving revision 1.20
diff -p -u -d -r1.20 nsfont.m
--- src/nsfont.m	14 Mar 2009 21:20:07 -0000	1.20
+++ src/nsfont.m	4 Apr 2009 08:56:59 -0000
@@ -658,7 +658,7 @@ nsfont_open (FRAME_PTR f, Lisp_Object fo
     hd = full_height - min_height;
 
     /* standard height, similar to Carbon. Emacs.app: was 0.5 by default. */
-    expand = 0.0; 
+    expand = 0.5;
     shrink = 1.0;
     hshrink = 1.0;