From: "Drew Adams" <drew.adams@oracle.com>
To: "'Suvayu Ali'" <fatkasuvayu+linux@gmail.com>
Cc: help-gnu-emacs@gnu.org, 'Patrick Wang' <p@patrickz.net>,
'Nathan LeClaire' <nathan.leclaire@gmail.com>
Subject: RE: Load color-theme in init.el
Date: Wed, 15 Aug 2012 14:18:24 -0700 [thread overview]
Message-ID: <BCE1CE3365CF4135A99F1FF6BD160B39@us.oracle.com> (raw)
In-Reply-To: <20120815203705.GA19002@kuru.dyndns-at-home.com>
> > > I finally figured out that apparently in Emacs 24
> > > color-theme is (slightly?) deprecated.
> >
> > No, color-theme is not at all deprecated. It has never
> > been part of GNU Emacs, so GNU Emacs cannot deprecate it.
> > It is a third-party library, color-theme.el, and it is still
> > available AFAIK.
>
> I believe starting with the following commit:
>
> commit 2faa2c5d69f36c29cdd3b654f4cc9c4b89c81e5a
> Author: Chong Yidong <cyd@gnu.org>
> Date: Mon Apr 23 02:04:54 2012 +0800
> * faces.el (face-spec-set): Stop supporting deprecated
> form of third arg.
>
> color-theme stopped working properly with Emacs 24. I switched to
> custom-theme soon after, so I don't know if the situation has changed.
OK, good to know, I guess. You are reporting that color-theme.el no longer
works with GNU Emacs. Sorry to hear that. I was reporting only that (a) GNU
Emacs cannot deprecate color-theme.el (by definition) and (b) color-theme.el is
still available.
But it should be straightforward to update color-theme.el to no longer use
`face-spec-set' (said without bothering to look at the code), should anyone want
to do that. It should be enough to use `face-set-attribute' (and perhaps
`face-spec-chooose'), to replace using `face-spec-set'.
Of course, there is no guarantee that with just that change color-theme.el will
work with Emacs 24.
On n'arrete pas le progres...
prev parent reply other threads:[~2012-08-15 21:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-21 16:12 Load color-theme in init.el Patrick Wang
2012-08-14 2:39 ` nathan.leclaire
2012-08-14 8:48 ` Peter Dyballa
2012-08-15 0:30 ` Nathan LeClaire
2012-08-15 1:23 ` Drew Adams
2012-08-15 13:26 ` Nathan LeClaire
2012-08-15 14:03 ` Drew Adams
2012-08-15 20:37 ` Suvayu Ali
2012-08-15 21:18 ` Drew Adams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BCE1CE3365CF4135A99F1FF6BD160B39@us.oracle.com \
--to=drew.adams@oracle.com \
--cc=fatkasuvayu+linux@gmail.com \
--cc=help-gnu-emacs@gnu.org \
--cc=nathan.leclaire@gmail.com \
--cc=p@patrickz.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.