From: Ken Raeburn <raeburn@raeburn.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 3892@emacsbugs.donarmstrong.com
Subject: bug#3892: corrupting load-in-progress value with "let"
Date: Thu, 23 Jul 2009 21:51:01 -0400 [thread overview]
Message-ID: <BCD1BAE7-231D-4FA4-9683-2EACCF3BBE69@raeburn.org> (raw)
In-Reply-To: <jwv8wieopby.fsf-monnier+emacsbugreports@gnu.org>
On Jul 23, 2009, at 21:14, Stefan Monnier wrote:
>> I'm working on the revised patch, but it occurs to me that this
>> way, some
>> broken bit of code could set load-in-progress to t at some point
>> when
>> nothing is being loaded, and it will never become nil again unless
>> explicitly reset.
>
> Isn't that a problem that already exists?
Not exactly... in the released code (and trunk before my first
change), it can explicitly be set to t at the top level, but it'll be
reset to nil after loading another file. And, the bug I was aiming to
fix initially, the counter (unseen by Lisp) can be set to 1 from some
higher number during nested loading, causing it to be set to nil when
returning back to enclosing load calls, but once you get back to the
top level the nil value is correct, and when the next load starts from
the top level it'll correctly be set to t (temporarily) again.
So the specbind version would make the first bug a little worse,
though it fixes the second.
> In any case such setting would be a bug, so I wouldn't worry about it.
Yeah, that's true enough...
>> A related issue: If we're changing the way it's set, should we
>> retain the
>> constraint that load-in-progress can only (appear to) hold boolean
>> values,
>> or let it hold any Lisp value instead?
>
> A boolean seems sufficient, I see no need to change it for now,
Okay, it doesn't seem like a big deal to me either way.
Ken
next prev parent reply other threads:[~2009-07-24 1:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87fxbslllh.fsf@cyd.mit.edu>
2009-07-21 4:01 ` bug#3892: corrupting load-in-progress value with "let" Ken Raeburn
2009-07-21 16:27 ` Stefan Monnier
2009-07-21 18:44 ` Ken Raeburn
2009-07-24 0:08 ` Ken Raeburn
2009-07-24 1:14 ` Stefan Monnier
2009-07-24 1:51 ` Ken Raeburn [this message]
2009-08-15 23:15 ` bug#3892: marked as done (corrupting load-in-progress value with "let") Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BCD1BAE7-231D-4FA4-9683-2EACCF3BBE69@raeburn.org \
--to=raeburn@raeburn.org \
--cc=3892@emacsbugs.donarmstrong.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.