From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Tobias Bading Newsgroups: gmane.emacs.bugs Subject: bug#34479: Incorrect classification of messages in compilation-mode buffer Date: Mon, 25 Feb 2019 14:26:38 +0100 Message-ID: References: <483a94fa-e01c-f81e-ca33-44acc4ba33dd@gmail.com> <6859a1c7-132d-3076-963f-25e177086f44@gmail.com> <838syho4xg.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="87751"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Daniel Lopez To: 34479@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 25 14:27:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gyGHr-000Mhv-AV for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 Feb 2019 14:27:15 +0100 Original-Received: from localhost ([127.0.0.1]:37425 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyGHq-0000lN-AA for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 Feb 2019 08:27:14 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40471) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyGHg-0000l4-Fy for bug-gnu-emacs@gnu.org; Mon, 25 Feb 2019 08:27:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gyGHe-0003O2-Sb for bug-gnu-emacs@gnu.org; Mon, 25 Feb 2019 08:27:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37393) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gyGHe-0003Ny-On for bug-gnu-emacs@gnu.org; Mon, 25 Feb 2019 08:27:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gyGHe-000222-JH for bug-gnu-emacs@gnu.org; Mon, 25 Feb 2019 08:27:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tobias Bading Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Feb 2019 13:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34479 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 34479-submit@debbugs.gnu.org id=B34479.15511012127791 (code B ref 34479); Mon, 25 Feb 2019 13:27:02 +0000 Original-Received: (at 34479) by debbugs.gnu.org; 25 Feb 2019 13:26:52 +0000 Original-Received: from localhost ([127.0.0.1]:50936 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gyGHS-00021Z-6D for submit@debbugs.gnu.org; Mon, 25 Feb 2019 08:26:52 -0500 Original-Received: from mout.web.de ([212.227.15.4]:59385) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gyGHQ-00021M-AN for 34479@debbugs.gnu.org; Mon, 25 Feb 2019 08:26:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1551101200; bh=+xpDIrqmOcbC8n0HURDWhzObvlj5iUyENlmt2oVGRI0=; h=X-UI-Sender-Class:Subject:From:In-Reply-To:Date:Cc:References:To; b=fn/cLrL2jHy2fTMjFaSeD8u/Dy3cp7ebC6YhLt1bjOlXORbYMBY5qyPWM4UsMAWtJ xrEmtMub3t2R65wGmaixQU5h0mgxL5vADuuHpQZ+nkmUwTc5w81F/0L6c6GMDN5opH BgOveDFuYjRp8e9AIAyrzy1aHqmC2M/YoQYqZ4r0= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from [192.168.2.107] ([84.143.148.53]) by smtp.web.de (mrweb001 [213.165.67.108]) with ESMTPSA (Nemesis) id 0M09uu-1hIwSi1mP6-00uLjQ; Mon, 25 Feb 2019 14:26:40 +0100 In-Reply-To: <838syho4xg.fsf@gnu.org> X-Mailer: Apple Mail (2.3124) X-Provags-ID: V03:K1:n4sj2QA03A8WEH4TuqJR0tCVC5Uht+tT9SJL/+KpIoGrPq0np4R Kdsh8VYukT2aPB+oyFuWQG8hzcxsKR750La+YJYqAnjok/KI/etZ53bBVES5pBzXoD+tLJV I9d7jpLWSoIEL8XJCxl9zk5gc8bgzvIJ+Y3X94h0TDpTBDZ2r4EM7FvkuMrokP3ktTnVN5T 09EYl4bdJ9e89vrW2OMkA== X-UI-Out-Filterresults: notjunk:1;V03:K0:uHu8tRRLKd0=:X0kyLhUClPnGnNFiJyPBLZ nmWKlNlw0gNJk2rReU3fTxtG430I1Lugsmrvvtdq5yK6D486hL2Q4fibrUEFLnp0tjSR67Jks INDaS1n5B30CtcAzD9g/AwUoMRVjqkwps5C8rU4IVps7TetEvtYWvo9y/Z02IFmCjRBdOWCeL 3i/CJQfHcSqEzsBssaCU7hQaMmTKBvNoPDtLUnlcBnw8i6SCJDfwdhrN5nq4eT8MXOn/rVT8m RnKlEMe2a1SKh66OJBYVgoxx5jkp0N4gqiYSGhFA+toI7BOiwshw+ZFo3MajONx78BCYZnjlX VS85/U5mBhRf/ReTbCvoXivi9u5bUjwndCgOZ/pC8Qi4d7ZKeYm01QJHR2Fc2kSbTmmDkNAEY bRXBOaMJdeXexcmxTAtejclnZ4uoUlG0Vokt6YsonYO9xOWF7kSSXC2EDlZdmJE56EStp2kde XEjXVmr6FyAgA5iigC7EjBWdv6zXbT00SSv1tLDTiXtN+2CBpeALrqND+qFC3miCzNBEgdvkM iIIjO+ahwSFYrELe9SGY6F8pxsLcVrzuEyyQTyqVaIghi55scOJNxG5+wiJzcwEUqj3PlmnoX 91EFFvCDhm+dh19TbDf6RRfspuBZojyXQfdorGmlxiFYlI2qd4nkTP7NUYZhZMRCSr/w35e3e UTmYzsIxxM2CgFYlo3FHGgKu+/vcPxCXsHGR2zxngV6GfElWTTl2bekyHGKCxoBzLVcG3aSVo ol77IAy8ZpPtvhx+w/6fUOClf6W65WxrnhbXnOoMKP96NQiU26MZdqAYadNueOJU3185fcmd X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:155763 Archived-At: I also discovered this bug a few days ago and came up with the same fix = as Daniel. However, there=E2=80=99s a small mistake in his patch which = results in incorrect error numbers in the mode line. The = compilation--note-type call should look like this: diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index 146af5a..368b088 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -1441,7 +1441,7 @@ compilation-parse-errors (let ((this-type (if (consp type) (compilation-type type) (or type 2)))) - (compilation--note-type type) + (compilation--note-type this-type) =20 (compilation--put-prop file 'font-lock-face Regards, Tobias