From: Tobias Bading <tbading@web.de>
To: 34479@debbugs.gnu.org
Cc: Daniel Lopez <daniel.lopez999@gmail.com>
Subject: bug#34479: Incorrect classification of messages in compilation-mode buffer
Date: Mon, 25 Feb 2019 14:26:38 +0100 [thread overview]
Message-ID: <BC11BD75-B2C8-49A7-9D5C-3550BFD87B58@web.de> (raw)
In-Reply-To: <838syho4xg.fsf@gnu.org>
I also discovered this bug a few days ago and came up with the same fix as Daniel. However, there’s a small mistake in his patch which results in incorrect error numbers in the mode line. The compilation--note-type call should look like this:
diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
index 146af5a..368b088 100644
--- a/lisp/progmodes/compile.el
+++ b/lisp/progmodes/compile.el
@@ -1441,7 +1441,7 @@ compilation-parse-errors
(let ((this-type (if (consp type)
(compilation-type type)
(or type 2))))
- (compilation--note-type type)
+ (compilation--note-type this-type)
(compilation--put-prop
file 'font-lock-face
Regards,
Tobias
next prev parent reply other threads:[~2019-02-25 13:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 16:00 bug#34479: Incorrect classification of messages in compilation-mode buffer Daniel Lopez
2019-02-14 16:05 ` Daniel Lopez
2019-02-15 8:02 ` Eli Zaretskii
2019-02-25 13:26 ` Tobias Bading [this message]
2019-02-25 16:03 ` Daniel Lopez
2019-03-01 10:07 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BC11BD75-B2C8-49A7-9D5C-3550BFD87B58@web.de \
--to=tbading@web.de \
--cc=34479@debbugs.gnu.org \
--cc=daniel.lopez999@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.