all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Herbert Euler <herberteuler@hotmail.com>
To: <emacs-devel@gnu.org>
Subject: Patch to pcomplete to make it work with shell-mode again
Date: Thu, 9 Jul 2009 16:27:42 +0800	[thread overview]
Message-ID: <BAY143-W12B2A2096F75CCE1E29E7FDA260@phx.gbl> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 343 bytes --]


After the new function `shell-dynamic-complete-filename' was added, pcomplete was broken.
The attached patch fixes it.

Regards,
Guanpeng Xu

_________________________________________________________________
Windows Live™: Keep your life in sync. Check it out!
http://windowslive.com/explore?ocid=TXT_TAGLM_WL_t1_allup_explore_012009

[-- Attachment #1.2: Type: text/html, Size: 514 bytes --]

[-- Attachment #2: pcomplete.patch --]
[-- Type: application/octet-stream, Size: 1149 bytes --]

Index: pcomplete.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/pcomplete.el,v
retrieving revision 1.39
diff -c -F '^(defun' -r1.39 pcomplete.el
*** pcomplete.el	5 Jan 2009 03:19:38 -0000	1.39
--- pcomplete.el	9 Jul 2009 08:26:38 -0000
*************** (defun pcomplete-comint-setup (completef
*** 590,597 ****
    (set (make-local-variable 'pcomplete-parse-arguments-function)
         'pcomplete-parse-comint-arguments)
    (make-local-variable completef-sym)
!   (let ((elem (memq 'comint-dynamic-complete-filename
! 		    (symbol-value completef-sym))))
      (if elem
  	(setcar elem 'pcomplete)
        (add-to-list completef-sym 'pcomplete))))
--- 590,599 ----
    (set (make-local-variable 'pcomplete-parse-arguments-function)
         'pcomplete-parse-comint-arguments)
    (make-local-variable completef-sym)
!   (let ((elem (or (memq 'comint-dynamic-complete-filename
! 			(symbol-value completef-sym))
! 		  (memq 'shell-dynamic-complete-filename
! 			(symbol-value completef-sym)))))
      (if elem
  	(setcar elem 'pcomplete)
        (add-to-list completef-sym 'pcomplete))))

             reply	other threads:[~2009-07-09  8:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-09  8:27 Herbert Euler [this message]
2009-07-12 16:20 ` Patch to pcomplete to make it work with shell-mode again Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BAY143-W12B2A2096F75CCE1E29E7FDA260@phx.gbl \
    --to=herberteuler@hotmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.