all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Herbert Euler" <herberteuler@hotmail.com>
To: monnier@iro.umontreal.ca, rudalics@gmx.at
Cc: emacs-devel@gnu.org
Subject: Re: Inconsistency in font-lock
Date: Thu, 26 Apr 2007 12:17:26 +0800	[thread overview]
Message-ID: <BAY143-F602E5C2B3DDD959DEF446DA480@phx.gbl> (raw)
In-Reply-To: <jwvk5vz3j7a.fsf-monnier+emacs@gnu.org>

> > It's not nice.  We should write:
> > (defun font-lock-default-fontify-region (beg end &optional loudly)
>
>I think we should fix the docstring instead and just say that the function
>is called with 3 arguments.  How that function accepts them is irrelevant
>(the function may have 4 optional arguments if the programmer feels like
>it).

Well, from the caller's point of view, the third argument is less
meaningful.  In my opinion,

    (funcall font-lock-fontify-region-function start end nil)

is a bit worse than

    (funcall font-lock-fontify-region-function start end)

since the third argument `nil' is a surprise here.  Only start and
end positions are necessary for operations on a region.

Regards,
Guanpeng Xu

_________________________________________________________________
Express yourself instantly with MSN Messenger! Download today it's FREE! 
http://messenger.msn.click-url.com/go/onm00200471ave/direct/01/

  reply	other threads:[~2007-04-26  4:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-25 15:35 Inconsistency in font-lock Herbert Euler
2007-04-25 20:54 ` martin rudalics
2007-04-26  3:13   ` Glenn Morris
2007-04-26  3:32   ` Stefan Monnier
2007-04-26  4:17     ` Herbert Euler [this message]
2007-04-26  6:17     ` martin rudalics
2007-04-26 14:04       ` Stefan Monnier
2007-04-26 15:06         ` Herbert Euler
2007-04-26 16:00           ` Stefan Monnier
2007-04-26 15:51         ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BAY143-F602E5C2B3DDD959DEF446DA480@phx.gbl \
    --to=herberteuler@hotmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.