all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Herbert Euler" <herberteuler@hotmail.com>
To: monnier@iro.umontreal.ca
Cc: emacs-devel@gnu.org
Subject: Re: Wrong comment in keymap.c
Date: Mon, 26 Mar 2007 12:24:59 +0800	[thread overview]
Message-ID: <BAY143-F37E5B3E9A6948154990FF0DA6F0@phx.gbl> (raw)
In-Reply-To: <jwv4po8epys.fsf-monnier+emacs@gnu.org>

> > Here is another one, for `read_key_sequence' in keyboard.c.
> > `first_binding' is always used with `submaps', shouldn't the
> > comment for it be `submaps', rather than `defs'?
>
>No, the comment is correct.  The "submaps[first_binding]" expressions are
>used to check whether that first binding is a prefix or not.  I.e. kind of
>like "KEYMAPP (defs[first_binding])".
>
>It's mostly set in follow_key:
>
>	  if (! NILP (defs[i]))
>	    first_binding = i;

Excuse me, but there are two ``first_binding''s in this file; I refered
the one in ``read_key_sequence''.  Please take a look at near line
8996:

  /* Find an accurate initial value for first_binding.  */
  for (first_binding = 0; first_binding < nmaps; first_binding++)
    if (! NILP (submaps[first_binding]))
      break;

Regards,
Guanpeng Xu

_________________________________________________________________
Express yourself instantly with MSN Messenger! Download today it's FREE! 
http://messenger.msn.click-url.com/go/onm00200471ave/direct/01/

  reply	other threads:[~2007-03-26  4:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-22 12:37 Wrong comment in keymap.c Herbert Euler
2007-03-23  1:25 ` Herbert Euler
2007-03-26  1:49   ` Stefan Monnier
2007-03-26  4:24     ` Herbert Euler [this message]
2007-03-26  5:50       ` Herbert Euler
2007-03-26  6:00         ` Herbert Euler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BAY143-F37E5B3E9A6948154990FF0DA6F0@phx.gbl \
    --to=herberteuler@hotmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.