From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Herbert Euler" Newsgroups: gmane.emacs.devel Subject: RE: Wrong comment in keymap.c Date: Fri, 23 Mar 2007 09:25:49 +0800 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; format=flowed X-Trace: sea.gmane.org 1174613166 9453 80.91.229.12 (23 Mar 2007 01:26:06 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 23 Mar 2007 01:26:06 +0000 (UTC) To: herberteuler@hotmail.com, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 23 02:26:00 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HUYXX-0005kG-3f for ged-emacs-devel@m.gmane.org; Fri, 23 Mar 2007 02:25:59 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HUYZN-00062i-9Q for ged-emacs-devel@m.gmane.org; Thu, 22 Mar 2007 20:27:53 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HUYZJ-0005qv-FN for emacs-devel@gnu.org; Thu, 22 Mar 2007 21:27:49 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HUYZH-0005bZ-IQ for emacs-devel@gnu.org; Thu, 22 Mar 2007 21:27:48 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HUYZH-0005at-FC for emacs-devel@gnu.org; Thu, 22 Mar 2007 20:27:47 -0500 Original-Received: from bay0-omc1-s2.bay0.hotmail.com ([65.54.246.74]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HUYXQ-0002He-5k for emacs-devel@gnu.org; Thu, 22 Mar 2007 21:25:52 -0400 Original-Received: from hotmail.com ([65.55.154.115]) by bay0-omc1-s2.bay0.hotmail.com with Microsoft SMTPSVC(6.0.3790.2668); Thu, 22 Mar 2007 18:25:50 -0700 Original-Received: from mail pickup service by hotmail.com with Microsoft SMTPSVC; Thu, 22 Mar 2007 18:25:50 -0700 Original-Received: from 65.55.154.123 by by143fd.bay143.hotmail.msn.com with HTTP; Fri, 23 Mar 2007 01:25:49 GMT X-Originating-IP: [216.145.54.158] X-Originating-Email: [herberteuler@hotmail.com] X-Sender: herberteuler@hotmail.com In-Reply-To: X-OriginalArrivalTime: 23 Mar 2007 01:25:50.0811 (UTC) FILETIME=[314522B0:01C76CEA] X-detected-kernel: Windows 2000 SP4, XP SP1+ X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:68347 Archived-At: Here is another one, for `read_key_sequence' in keyboard.c. `first_binding' is always used with `submaps', shouldn't the comment for it be `submaps', rather than `defs'? Patch: *** keyboard.c.~1.753.2.58.~ Mon Nov 13 10:58:22 2006 --- keyboard.c Fri Mar 23 09:21:18 2007 *************** read_key_sequence (keybuf, bufsize, prom *** 8656,8664 **** of the place where a mouse click occurred. */ volatile int localized_local_map = 0; ! /* The index in defs[] of the first keymap that has a binding for this key sequence. In other words, the lowest i such that ! defs[i] is non-nil. */ volatile int first_binding; /* Index of the first key that has no binding. It is useless to try fkey.start larger than that. */ --- 8656,8664 ---- of the place where a mouse click occurred. */ volatile int localized_local_map = 0; ! /* The index in submaps[] of the first keymap that has a binding for this key sequence. In other words, the lowest i such that ! submaps[i] is non-nil. */ volatile int first_binding; /* Index of the first key that has no binding. It is useless to try fkey.start larger than that. */ Regards, Guanpeng Xu _________________________________________________________________ Express yourself instantly with MSN Messenger! Download today it's FREE! http://messenger.msn.click-url.com/go/onm00200471ave/direct/01/