From: "Herbert Euler" <herberteuler@hotmail.com>
To: herberteuler@hotmail.com, emacs-devel@gnu.org
Subject: RE: Wrong comment in keymap.c
Date: Fri, 23 Mar 2007 09:25:49 +0800 [thread overview]
Message-ID: <BAY143-F35EEC78EF2E0FDE64B488CDA6A0@phx.gbl> (raw)
In-Reply-To: <BAY143-F3DA86CE0D635A0D2B5993DA6B0@phx.gbl>
Here is another one, for `read_key_sequence' in keyboard.c.
`first_binding' is always used with `submaps', shouldn't the
comment for it be `submaps', rather than `defs'? Patch:
*** keyboard.c.~1.753.2.58.~ Mon Nov 13 10:58:22 2006
--- keyboard.c Fri Mar 23 09:21:18 2007
*************** read_key_sequence (keybuf, bufsize, prom
*** 8656,8664 ****
of the place where a mouse click occurred. */
volatile int localized_local_map = 0;
! /* The index in defs[] of the first keymap that has a binding for
this key sequence. In other words, the lowest i such that
! defs[i] is non-nil. */
volatile int first_binding;
/* Index of the first key that has no binding.
It is useless to try fkey.start larger than that. */
--- 8656,8664 ----
of the place where a mouse click occurred. */
volatile int localized_local_map = 0;
! /* The index in submaps[] of the first keymap that has a binding for
this key sequence. In other words, the lowest i such that
! submaps[i] is non-nil. */
volatile int first_binding;
/* Index of the first key that has no binding.
It is useless to try fkey.start larger than that. */
Regards,
Guanpeng Xu
_________________________________________________________________
Express yourself instantly with MSN Messenger! Download today it's FREE!
http://messenger.msn.click-url.com/go/onm00200471ave/direct/01/
next prev parent reply other threads:[~2007-03-23 1:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-22 12:37 Wrong comment in keymap.c Herbert Euler
2007-03-23 1:25 ` Herbert Euler [this message]
2007-03-26 1:49 ` Stefan Monnier
2007-03-26 4:24 ` Herbert Euler
2007-03-26 5:50 ` Herbert Euler
2007-03-26 6:00 ` Herbert Euler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BAY143-F35EEC78EF2E0FDE64B488CDA6A0@phx.gbl \
--to=herberteuler@hotmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.