Re: proposition about bookmark-buffer-file-name in bookmark.el

["Toru TSUNEYOSHI" <t_tuneyosi@hotmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1382 bytes --]

Thank you for replying.

----- Original Message ----- 
From: "Karl Fogel" <kfogel@red-bean.com>
To: "Toru TSUNEYOSHI" <t_tuneyosi@hotmail.com>
Cc: <emacs-devel@gnu.org>
Sent: Wednesday, November 19, 2008 4:37 PM
Subject: Re: proposition about bookmark-buffer-file-name in bookmark.el


> "Toru TSUNEYOSHI" <t_tuneyosi@hotmail.com> writes:
> > I have a proposition.
> > (I use GNU Emacs 22.3.1 (i386-msvc-nt5.0.2195).)
> >
> > Now, `bookmark-buffer-file-name' in bookmark.el do
> > `abbreviate-file-name' buffer-file-name only.
> > So, I wish this function do `abbreviate-file-name' dired-directory (and
> > Info-current-file) on next version of Emacs.
> 
> This sounds reasonable to me, but could you give examples of what the
> new names would look like for those kinds of bookmarks?

Sorry, I can't understand you clearly.

Anyway, I wish that `bookmark-buffer-file-name' returns dired-directory
relative to `~/'.

examples of `bookmark-buffer-file-name' processing:

  case:
    home directory:  "d:/home/user/"
    dired-directory: "d:/home/user/xyz/"

    (bookmark-buffer-file-name)
    now
      => "d:/home/user/xyz/"
    wish
      => "~/xyz/"

> 
> (By the way, expressing the proposed change in 'patch' format is
> probably the most precise way to communicate it.)
> 
> Thanks,
> -Karl

Yes.
I use `defadvice' in practice.
But I made a patch for bookmark.el temporarily.

[-- Attachment #2: bookmark.el.diff --]
[-- Type: application/octet-stream, Size: 1391 bytes --]

--- bookmark.el.original	2008-01-07 11:45:03.000000000 +0900
+++ bookmark.el	2008-11-19 20:45:26.331974400 +0900
@@ -1007,18 +1007,20 @@
 (defun bookmark-buffer-file-name ()
   "Return the current buffer's file in a way useful for bookmarks.
 For example, if this is a Info buffer, return the Info file's name."
-  (cond
-   ((eq major-mode 'Info-mode)
-    Info-current-file)
-   (buffer-file-name
-    ;; Abbreviate the path, both so it's shorter and so it's more
-    ;; portable.  E.g., the user's home dir might be a different
-    ;; path on different machines, but "~/" will still reach it.
-    (abbreviate-file-name buffer-file-name))
-   ((and (boundp 'dired-directory) dired-directory)
-    (if (stringp dired-directory)
-        dired-directory
-      (car dired-directory)))))
+  (let (file)
+    (setq file (cond
+		((eq major-mode 'Info-mode)
+		 Info-current-file)
+		(buffer-file-name
+		 ;; Abbreviate the path, both so it's shorter and so it's more
+		 ;; portable.  E.g., the user's home dir might be a different
+		 ;; path on different machines, but "~/" will still reach it.
+		 buffer-file-name)
+		((and (boundp 'dired-directory) dired-directory)
+		 (if (stringp dired-directory)
+		     dired-directory
+		   (car dired-directory)))))
+    (and file (abbreviate-file-name file))))
 
 
 (defun bookmark-maybe-load-default-file ()