all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* C++ name and add-log-current-defun
@ 2006-09-21 12:39 Herbert Euler
  2006-09-21 15:05 ` Kevin Rodgers
  0 siblings, 1 reply; 10+ messages in thread
From: Herbert Euler @ 2006-09-21 12:39 UTC (permalink / raw)


add-log-current-defun cannot handle C++ names well.  For
example, the current function:

    int some_class::some_method(int arg)
    {
        // ...
    }

If one invoke add-change-log-entry-other-window when point
is in this function, one would get

    * some_file.cpp (class::some_method):

rather than

    * some_file.cpp (some_class::some_method):

This is because add-log-current-defun in add-log.el calculates
the function name wrong.  Below is the code:

    ;; Now find the right beginning of the name.
    ;; Include certain keywords if they
    ;; precede the name.
    (setq middle (point))
    (forward-word -1)
    ;; Is this C++ method?
    ;; ...

(forward-word -1) wouldn't put point before `some_class',
but puts point before `c' in `some_class'.

How about changing it to like this?

    (while (not (looking-back "\\(^\\|[ \t]\\)"))
      (backward-word 1))

Regards,
Guanpeng Xu

_________________________________________________________________
Express yourself instantly with MSN Messenger! Download today it's FREE! 
http://messenger.msn.click-url.com/go/onm00200471ave/direct/01/

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2006-12-27  7:50 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-21 12:39 C++ name and add-log-current-defun Herbert Euler
2006-09-21 15:05 ` Kevin Rodgers
2006-09-22  4:36   ` Masatake YAMATO
2006-09-22  7:30     ` Herbert Euler
2006-09-22 10:55       ` Masatake YAMATO
2006-09-22 14:01         ` Herbert Euler
2006-12-20  2:26     ` Herbert Euler
2006-12-22 20:50       ` Kevin Rodgers
2006-12-23  3:27         ` Herbert Euler
2006-12-27  7:50           ` Kevin Rodgers

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.