From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Herbert Euler" Newsgroups: gmane.emacs.devel Subject: Re: Some problems in `add-log-current-defun' Date: Mon, 01 Jan 2007 09:27:33 +0800 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; format=flowed X-Trace: sea.gmane.org 1167614872 22114 80.91.229.12 (1 Jan 2007 01:27:52 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 1 Jan 2007 01:27:52 +0000 (UTC) Cc: jet@gyve.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 01 02:27:50 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1H1Bxu-0005EO-HC for ged-emacs-devel@m.gmane.org; Mon, 01 Jan 2007 02:27:50 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1H1Bxt-0008Bp-Ue for ged-emacs-devel@m.gmane.org; Sun, 31 Dec 2006 20:27:50 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1H1Bxi-0008B7-VL for emacs-devel@gnu.org; Sun, 31 Dec 2006 20:27:39 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1H1Bxh-00089U-CW for emacs-devel@gnu.org; Sun, 31 Dec 2006 20:27:38 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1H1Bxh-00089R-7e for emacs-devel@gnu.org; Sun, 31 Dec 2006 20:27:37 -0500 Original-Received: from [65.54.246.147] (helo=bay0-omc2-s11.bay0.hotmail.com) by monty-python.gnu.org with esmtp (Exim 4.52) id 1H1Bxf-00039k-OO; Sun, 31 Dec 2006 20:27:35 -0500 Original-Received: from hotmail.com ([64.4.26.25]) by bay0-omc2-s11.bay0.hotmail.com with Microsoft SMTPSVC(6.0.3790.2668); Sun, 31 Dec 2006 17:27:35 -0800 Original-Received: from mail pickup service by hotmail.com with Microsoft SMTPSVC; Sun, 31 Dec 2006 17:27:34 -0800 Original-Received: from 64.4.26.200 by by112fd.bay112.hotmail.msn.com with HTTP; Mon, 01 Jan 2007 01:27:33 GMT X-Originating-IP: [221.220.245.226] X-Originating-Email: [herberteuler@hotmail.com] X-Sender: herberteuler@hotmail.com In-Reply-To: Original-To: rms@gnu.org X-OriginalArrivalTime: 01 Jan 2007 01:27:34.0878 (UTC) FILETIME=[03D6BFE0:01C72D44] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:64589 Archived-At: >I would like to install your fix for problems I, II and III, >but it is big enough that we need legal papers for it. >I will send you what is needed to do this, and in the mean time, >I will save that patch. I am trying to get the postal address and will send this mail later. Thank you. Here I'd like to say something for the fix of IV. This change 2006-12-26 Guanpeng Xu (tiny change) * add-log.el (add-log-current-defun): Call `forward-sexp' multiple times to pick a member function name defined as part of nested classes/namespaces. created a bug. For the following example, struct abc { -!-}; If point is at -!-, `add-log-current-defun' will return ``abc'' rather than the desired, old ``struct abc''. I found it when trying to solve IV. So, please consider to either revert the above change, or install the fix of IV. I think it is necessary to keep the behavior correct for at least C, and based on my test I think there is little risk of breaking something else to install the fix of IV. Regards, Guanpeng Xu _________________________________________________________________ FREE pop-up blocking with the new MSN Toolbar - get it now! http://toolbar.msn.click-url.com/go/onm00200415ave/direct/01/