From: "Herbert Euler" <herberteuler@hotmail.com>
Cc: jet@gyve.org, emacs-devel@gnu.org
Subject: Re: Some problems in `add-log-current-defun'
Date: Mon, 01 Jan 2007 09:27:33 +0800 [thread overview]
Message-ID: <BAY112-F1511BD581400C647767013DABB0@phx.gbl> (raw)
In-Reply-To: <E1H18wC-0007Rn-Rm@fencepost.gnu.org>
>I would like to install your fix for problems I, II and III,
>but it is big enough that we need legal papers for it.
>I will send you what is needed to do this, and in the mean time,
>I will save that patch.
I am trying to get the postal address and will send this mail
later. Thank you.
Here I'd like to say something for the fix of IV. This change
2006-12-26 Guanpeng Xu <herberteuler@hotmail.com> (tiny change)
* add-log.el (add-log-current-defun): Call `forward-sexp'
multiple times to pick a member function name defined as
part of nested classes/namespaces.
created a bug. For the following example,
struct abc {
-!-};
If point is at -!-, `add-log-current-defun' will return ``abc'' rather
than the desired, old ``struct abc''. I found it when trying to
solve IV. So, please consider to either revert the above change,
or install the fix of IV. I think it is necessary to keep the behavior
correct for at least C, and based on my test I think there is little
risk of breaking something else to install the fix of IV.
Regards,
Guanpeng Xu
_________________________________________________________________
FREE pop-up blocking with the new MSN Toolbar - get it now!
http://toolbar.msn.click-url.com/go/onm00200415ave/direct/01/
next prev parent reply other threads:[~2007-01-01 1:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-31 8:28 Some problems in `add-log-current-defun' Herbert Euler
2006-12-31 22:13 ` Richard Stallman
2007-01-01 1:27 ` Herbert Euler [this message]
2007-01-02 23:35 ` Stefan Monnier
2007-01-03 21:11 ` Richard Stallman
-- strict thread matches above, loose matches on Subject: below --
2006-12-27 10:32 Herbert Euler
2006-12-27 10:45 ` David Kastrup
2006-12-27 11:48 ` Masatake YAMATO
2006-12-27 12:22 ` David Kastrup
2006-12-27 11:55 ` Masatake YAMATO
2006-12-27 13:46 ` Masatake YAMATO
2006-12-27 21:17 ` Richard Stallman
2006-12-28 12:41 ` Masatake YAMATO
2006-12-29 15:44 ` Richard Stallman
2006-12-30 4:55 ` Masatake YAMATO
2006-12-30 18:24 ` Richard Stallman
2006-12-28 12:47 ` Herbert Euler
2006-12-29 15:44 ` Richard Stallman
2006-12-29 3:10 ` Herbert Euler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BAY112-F1511BD581400C647767013DABB0@phx.gbl \
--to=herberteuler@hotmail.com \
--cc=emacs-devel@gnu.org \
--cc=jet@gyve.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.