Re: Patch make configure.bat support --cflags and --ldflags options that include quotes

[Ben Key <bkey76@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1382 bytes --]

Eli Zaretskii wrote:

> Maybe I'm missing something, but where is the fallback, exactly?

The code that you refrenced is simply not called in the fallback case, due
to the following code

:usercflags
if "%use_extensions%" == "1" goto ucflagex
goto ucflagne

The code you referred to is in the ucflagex case, but, if command extensions
are not enabled, the ucflagne case is used.  In the ucflagne case there are
the following lines.

set usercflags=%usercflags%%sep1%%1
set fusercflags=%usercflags%

The first of these lines sets usercflags without attempting to use the
command extensions magic that strips quotes and thus providing support for
options in the form of -DFOO=BAR as long as they are enclosed in quotes and
the second line sets fusercflags so that it simply contains the value of
usercflags

The line latter in the file that you referred to,
if (%docflags%) == (Y) echo #define USER_CFLAGS " %fusercflags%">>config.tmp
, uses only the fusercflags variable which is fine.  This is because of the
fact that, even if command extensions are not enabled, the fusercflags
variable will be set to the appropriate value.  The fusercflags variable will
have the same value as the usercflags variable if command extensions are not
available and will be equal to the usercflags variable with all the quotes
escaped by the backslash character if command extensions are available.

[-- Attachment #2: Type: text/html, Size: 1796 bytes --]