From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: after-find-file-from-revert-buffer Date: Wed, 6 Apr 2011 19:03:14 +0200 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1302109464 16340 80.91.229.12 (6 Apr 2011 17:04:24 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 6 Apr 2011 17:04:24 +0000 (UTC) Cc: Emacs developers To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 06 19:04:19 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q7W9H-0006pj-LL for ged-emacs-devel@m.gmane.org; Wed, 06 Apr 2011 19:04:14 +0200 Original-Received: from localhost ([127.0.0.1]:48516 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q7W9B-0006iB-Ek for ged-emacs-devel@m.gmane.org; Wed, 06 Apr 2011 13:04:01 -0400 Original-Received: from [140.186.70.92] (port=37645 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q7W96-0006dF-Il for emacs-devel@gnu.org; Wed, 06 Apr 2011 13:03:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q7W95-0000zD-91 for emacs-devel@gnu.org; Wed, 06 Apr 2011 13:03:56 -0400 Original-Received: from mail-gy0-f169.google.com ([209.85.160.169]:63852) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q7W95-0000yt-42 for emacs-devel@gnu.org; Wed, 06 Apr 2011 13:03:55 -0400 Original-Received: by gyd8 with SMTP id 8so796331gyd.0 for ; Wed, 06 Apr 2011 10:03:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type:content-transfer-encoding; bh=RFjfxrQvuFd9/O0nszg5OlKg2A4yyC8FvK1tJrEUyZM=; b=fX+G0vHlP1TXMhCx/HneFVQH0PrNMsj9XAjtVtNuxq2TTOC85Icw+szdtMaB4mDBKW miJTo/U+dtvd4zyyknUXGg942nMCvKccl/nYr1jMbCH4VwCbEZf2mdd2iOTrUCIY1dK3 zHqIMSnBvI6rqk77z+2og4o/bSb6OqMn2/oWo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=Ep84/04DLZjr/NeZ3kqtAoSYC13YYDs5JdX/MTqRu5KEtlT2fjesS5iySmcV0Q++XR 7aHqQAo8MzWi8yD/8OI0r3birhHIX9wrgv2GrjB3Ix1w1j0XYup5e8TGZD6eZjokYtgE 2e297/MmCmLTn5a/g2aSV1tWm6M/DtQhk9ztk= Original-Received: by 10.236.185.129 with SMTP id u1mr753872yhm.409.1302109434143; Wed, 06 Apr 2011 10:03:54 -0700 (PDT) Original-Received: by 10.147.182.17 with HTTP; Wed, 6 Apr 2011 10:03:14 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.160.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:138254 Archived-At: On Wed, Apr 6, 2011 at 18:51, Stefan Monnier wro= te: > I was thinking of using a revert-buffer-function of the form > > =C2=A0(=CE=BB (&rest args) > =C2=A0 =C2=A0(let ((save-place-in-revert-buffer t)) > =C2=A0 =C2=A0 =C2=A0(apply revert-buffer-default args))) > >> (defun revert-buffer (...) >> =C2=A0 =C2=A0(let ((revert-buffer-in-progress t)) >> =C2=A0 =C2=A0 =C2=A0 ...)) Global, you mean? I'm not sure it's worth the hassle. > Yes, that's is better. OK, I'll install that. > I guess you could use a single let that covers both branches of the `if'. IMO, it seems ugly to wrap the whole function just to add a variable. But it's your call. =C2=A0 =C2=A0 Juanma