From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.bugs Subject: bug#8911: bs-cycle-next deletes window in some cases. Date: Mon, 27 Jun 2011 03:53:29 +0200 Message-ID: References: <4E009EB0.1050903@gmx.at> <181538AC4C8B4765A99060E0425B9AB5@us.oracle.com> <9170F33E41584E0B8D96DD5EFC84599E@us.oracle.com> <8E864413162C4814BE8EFFD0C1FA1989@us.oracle.com> <4E06FBF8.9040205@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1309139725 12069 80.91.229.12 (27 Jun 2011 01:55:25 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 27 Jun 2011 01:55:25 +0000 (UTC) Cc: 8911@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 27 03:55:21 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Qb12n-0000sS-EH for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 Jun 2011 03:55:21 +0200 Original-Received: from localhost ([::1]:50904 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qb12m-0000LO-9b for geb-bug-gnu-emacs@m.gmane.org; Sun, 26 Jun 2011 21:55:20 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:60238) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qb12X-0000KK-8g for bug-gnu-emacs@gnu.org; Sun, 26 Jun 2011 21:55:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qb12U-00087R-Dp for bug-gnu-emacs@gnu.org; Sun, 26 Jun 2011 21:55:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58103) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qb12U-00087M-8t for bug-gnu-emacs@gnu.org; Sun, 26 Jun 2011 21:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Qb12T-0002Nt-Mo; Sun, 26 Jun 2011 21:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juanma Barranquero Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Jun 2011 01:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8911 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8911-submit@debbugs.gnu.org id=B8911.13091396629120 (code B ref 8911); Mon, 27 Jun 2011 01:55:01 +0000 Original-Received: (at 8911) by debbugs.gnu.org; 27 Jun 2011 01:54:22 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qb11p-0002N3-8K for submit@debbugs.gnu.org; Sun, 26 Jun 2011 21:54:21 -0400 Original-Received: from mail-pz0-f44.google.com ([209.85.210.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qb11j-0002Ml-9O for 8911@debbugs.gnu.org; Sun, 26 Jun 2011 21:54:19 -0400 Original-Received: by pzk5 with SMTP id 5so2679172pzk.3 for <8911@debbugs.gnu.org>; Sun, 26 Jun 2011 18:54:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type:content-transfer-encoding; bh=F8+DP3k1k3k1I6yOaO1auQjRNBe0KGsiznzf8stM/A0=; b=FPlgRv6ewL1ysM/xft5pK1L6UcRJXxwjv4xTS1os4tiwJBMvMZYfkjxnVUFc3BO0Xx V4p5dOZcbViUSqnUsb5h7Fqb3E1S+EUSUcKOMfr37cCRo01bR+y2wE33RoNLkAxxdj4J WawHRY/lnLzcJPX/KD2oIIr/nluF1JZ6/7wk4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=ZwaT4yMBjZJmb/0Wk+fIm350ieATZX8HsPq6KprShz2FLTh25D+7JLRpqv7wK7VtbO xfiptd36CTu5uXodZs9OuTdBxnqIZc7VNvwX3UAZLYvVWVbKDaWoVUhZLsHEcpoc6+0e oI4/065wTyup9qTozUBPfwsn4cr3QvQjnsRXE= Original-Received: by 10.143.12.16 with SMTP id p16mr923516wfi.50.1309139649380; Sun, 26 Jun 2011 18:54:09 -0700 (PDT) Original-Received: by 10.142.173.16 with HTTP; Sun, 26 Jun 2011 18:53:29 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 26 Jun 2011 21:55:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:47523 Archived-At: On Mon, Jun 27, 2011 at 03:30, Stefan Monnier wr= ote: > I'm not sure about the third (isn't it also fixed by passing a non-nil > arg to bury-buffer?) Well, yes, but that means "fixing" it everywhere; I mean: emacs -Q M-: (set-window-dedicated-p (selected-window) t) M-x bury-buffer and the frame is iconified. It shouldn't. > but for the second the right fix is to remove the > "fallback on pop-to-buffer" from switch-to-buffer. =C2=A0Of course, that = will > (re)introduce new bugs which we could/should "fix" by marking > switch-to-buffer (and find-file and maybe a few more) as "don't call > from Elisp". If switch-to-buffer is changed not to fallback on pop-to-buffer, why shouldn't it be called from elisp? In the case of bs-cycle-next: (unless (window-dedicated-p (selected-window)) ;; We don't want the frame iconified if the only window in the fr= ame ;; happens to be dedicated (bury-buffer (current-buffer))) (switch-to-buffer next) the current switch-to-buffer causes the unwanted-splitting behavior. Changing it to pop-to-buffer-same-window, as its docstring suggests, would still cause the same problem. =C2=A0 =C2=A0 Juanma