all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Configure with --enable-checking=stringoverrun has no effect
@ 2011-04-21  1:02 Ben Key
  2011-04-22 18:16 ` Glenn Morris
  0 siblings, 1 reply; 2+ messages in thread
From: Ben Key @ 2011-04-21  1:02 UTC (permalink / raw)
  To: Emacs-devel

[-- Attachment #1: Type: text/plain, Size: 725 bytes --]

Hello,

Running configure with  --enable-checking=stringoverrun has no effect in
that GC_CHECK_STRING_OVERRUN is not defined in the resulting config.h file.

I believe I know why this is happening.  On line 278,
ac_gc_check_string_overrun is set when the stringoverrun option is
specified.  Then on line 297 is the following test.
  if test x$ac_gc_check_stringoverrun != x ; then
(Note that there is no _ between string and overrun).

I believe that all that is necessary to fix this is to change line 297 to
the following, but I cannot test it because I do not have the correct
version of autoconf installed.
  if test x$ac_gc_check_string_overrun != x ; then

Please let me know if I should go ahead and make this change.

[-- Attachment #2: Type: text/html, Size: 841 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Configure with --enable-checking=stringoverrun has no effect
  2011-04-21  1:02 Configure with --enable-checking=stringoverrun has no effect Ben Key
@ 2011-04-22 18:16 ` Glenn Morris
  0 siblings, 0 replies; 2+ messages in thread
From: Glenn Morris @ 2011-04-22 18:16 UTC (permalink / raw)
  To: Ben Key; +Cc: Emacs-devel

Ben Key wrote:

> I believe that all that is necessary to fix this is to change line 297 to
> the following, but I cannot test it because I do not have the correct
> version of autoconf installed.
>   if test x$ac_gc_check_string_overrun != x ; then
>
> Please let me know if I should go ahead and make this change.

Yes please. It looks obviously correct. You could edit configure directly
to test it (or install autoconf of course).



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-04-22 18:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-21  1:02 Configure with --enable-checking=stringoverrun has no effect Ben Key
2011-04-22 18:16 ` Glenn Morris

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.