all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#8841: 23.1.90; Bug in cl-seq's `union' implementation
@ 2011-06-12  3:30 Thunk Out
  2011-06-12 18:36 ` Daniel Colascione
  2016-06-02  2:00 ` Noam Postavsky
  0 siblings, 2 replies; 3+ messages in thread
From: Thunk Out @ 2011-06-12  3:30 UTC (permalink / raw)
  To: 8841

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

There's a bug in cl-seq's `union' implementation.

The second clause in its `cond' tests CL-LIST1 and CL-LIST2 for
`equal'ity, not taking :test into account:

    ((equal cl-list1 cl-list2) cl-list1)

So, for example:

    (union '("foo") '("foo") :test '=)  =>  ("foo")

But:

    (union '("foo") '("bar") :test '=)  =>  **error**



-tlh

[-- Attachment #2: Type: text/html, Size: 662 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#8841: 23.1.90; Bug in cl-seq's `union' implementation
  2011-06-12  3:30 bug#8841: 23.1.90; Bug in cl-seq's `union' implementation Thunk Out
@ 2011-06-12 18:36 ` Daniel Colascione
  2016-06-02  2:00 ` Noam Postavsky
  1 sibling, 0 replies; 3+ messages in thread
From: Daniel Colascione @ 2011-06-12 18:36 UTC (permalink / raw)
  To: 8841

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 6/11/11 8:30 PM, Thunk Out wrote:
> There's a bug in cl-seq's `union' implementation.
> 
> The second clause in its `cond' tests CL-LIST1 and CL-LIST2 for
> `equal'ity, not taking :test into account:
> 
>     ((equal cl-list1 cl-list2) cl-list1)
> 
> So, for example:
> 
>     (union '("foo") '("foo") :test '=)  =>  ("foo")
> 
> But:
> 
>     (union '("foo") '("bar") :test '=)  =>  **error**
> 
> 
> 
> -tlh
> 

Note that this problem also affects other functions in cl-seq. I'm also
not entire sure why there's a special case in union for numbers.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (Darwin)

iEYEARECAAYFAk31BxUACgkQ17c2LVA10VvTTQCfdwOjUgweUMTKAiAsbvP6+TWv
yZwAn2KQPgLcke2ibtDZ8ZeEkGFQHiOp
=WUWg
-----END PGP SIGNATURE-----






^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#8841: 23.1.90; Bug in cl-seq's `union' implementation
  2011-06-12  3:30 bug#8841: 23.1.90; Bug in cl-seq's `union' implementation Thunk Out
  2011-06-12 18:36 ` Daniel Colascione
@ 2016-06-02  2:00 ` Noam Postavsky
  1 sibling, 0 replies; 3+ messages in thread
From: Noam Postavsky @ 2016-06-02  2:00 UTC (permalink / raw)
  To: 8841

found 8841 23.4
found 8841 24.3
found 8841 24.5
fixed 8841 25.0.94
close 8841
quit


Seems to have been fixed in Emacs 25





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-06-02  2:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-12  3:30 bug#8841: 23.1.90; Bug in cl-seq's `union' implementation Thunk Out
2011-06-12 18:36 ` Daniel Colascione
2016-06-02  2:00 ` Noam Postavsky

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.