From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#9899: 24.0.90; change in menu item representation Date: Fri, 28 Oct 2011 13:01:07 -0700 Message-ID: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1319832140 9055 80.91.229.12 (28 Oct 2011 20:02:20 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 28 Oct 2011 20:02:20 +0000 (UTC) To: 9899@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 28 22:02:15 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RJsd5-0006hN-6M for geb-bug-gnu-emacs@m.gmane.org; Fri, 28 Oct 2011 22:02:15 +0200 Original-Received: from localhost ([::1]:40540 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJsd4-0002CP-Fi for geb-bug-gnu-emacs@m.gmane.org; Fri, 28 Oct 2011 16:02:14 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:41709) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJsd0-0002C2-P9 for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2011 16:02:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RJscw-0007Sr-TS for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2011 16:02:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37545) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJscw-0007Sn-Qf for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2011 16:02:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RJseo-0001Dn-7G for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2011 16:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Oct 2011 20:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 9899 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: Original-Received: via spool by submit@debbugs.gnu.org id=B.13198321954637 (code B ref -1); Fri, 28 Oct 2011 20:04:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 28 Oct 2011 20:03:15 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RJse3-0001Cj-1y for submit@debbugs.gnu.org; Fri, 28 Oct 2011 16:03:15 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RJse0-0001Ca-Cf for submit@debbugs.gnu.org; Fri, 28 Oct 2011 16:03:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RJsc7-0007Ow-Dg for submit@debbugs.gnu.org; Fri, 28 Oct 2011 16:01:16 -0400 Original-Received: from lists.gnu.org ([140.186.70.17]:56701) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJsc7-0007Os-Az for submit@debbugs.gnu.org; Fri, 28 Oct 2011 16:01:15 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:41575) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJsc5-000287-Tl for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2011 16:01:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RJsc4-0007Nh-I5 for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2011 16:01:13 -0400 Original-Received: from acsinet15.oracle.com ([141.146.126.227]:41783) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJsc4-0007NR-8A for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2011 16:01:12 -0400 Original-Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by acsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id p9SK1A05013883 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 28 Oct 2011 20:01:10 GMT Original-Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p9SK19NN009021 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 28 Oct 2011 20:01:09 GMT Original-Received: from abhmt112.oracle.com (abhmt112.oracle.com [141.146.116.64]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p9SK13xQ020761 for ; Fri, 28 Oct 2011 15:01:04 -0500 Original-Received: from dradamslap1 (/10.159.41.33) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 28 Oct 2011 13:01:03 -0700 X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcyVrFSrHijDekAdQ1CU/Gd65mNVsg== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6109 X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090201.4EAB0A06.014D,ss=1,re=0.000,fgs=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Fri, 28 Oct 2011 16:04:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:53260 Archived-At: Apparently, in Emacs 23, you changed the cached representation of menu items. Scanning the C code in keymap.c and keyboard.c suggests that the caching of the key sequence is no longer done, and if already done somewhere else is ignored (skipped over). And yet, as late as Emacs 23.3, this remains in the doc (elisp) Extended Menu Items: "When an equivalent keyboard key binding is cached, the extended menu item binding looks like this: (menu-item ITEM-NAME REAL-BINDING (KEY-BINDING-DATA) . ITEM-PROPERTY-LIST)" That text was removed for Emacs 24, but AFAICT it was already untrue for Emacs 23 and should have been removed then. There was no such caching even in 23 AFAICT - no (KEY-BINDING-DATA). That's what I see in the debugger. Obviously, this change breaks 3rd party/user code that takes advantage of (KEY-BINDING-DATA). The bug I'm reporting is to ask you to at least mention this change in NEWS, or if possible in NEWS.23. I also tried to find some mention of this change in emacs-devel@gnu.org, but I couldn't find any mention, let alone a proposal and discussion. Admittedly, it was hard to search for this, so I might have overlooked a thread about it. This change is unfortunate, as it means that any code that wants to use the already determined key representation must take the time needed to look up the key afresh. For menu-navigation code such as lacarte.el, for instance, the key is included as part of the menu-item text available for completion, and this change means taking extra time, for each menu item, to look up a possible key binding. Why do you keep moving stuff to C, instead of moving C stuff to Lisp? Emacs should be as transparent and modifiable via Lisp as possible. That's part of its being "the extensible editor". You seem to be working against that spirit, which is the heart of Emacs. Why? In GNU Emacs 24.0.90.1 (i386-mingw-nt5.1.2600) of 2011-10-24 on MARVIN Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.6) --no-opt --cflags -I"D:/devel/emacs/libs/libXpm-3.5.8/include" -I"D:/devel/emacs/libs/libXpm-3.5.8/src" -I"D:/devel/emacs/libs/libpng-dev_1.4.3-1/include" -I"D:/devel/emacs/libs/zlib-dev_1.2.5-2/include" -I"D:/devel/emacs/libs/giflib-4.1.4-1/include" -I"D:/devel/emacs/libs/jpeg-6b-4/include" -I"D:/devel/emacs/libs/tiff-3.8.2-1/include" -I"D:/devel/emacs/libs/gnutls-2.10.1/include" --ldflags -L"D:/devel/emacs/libs/gnutls-2.10.1/lib"'