From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.devel Subject: RE: set-face-attribute and floating point :height values Date: Mon, 31 Jan 2011 14:04:11 -0800 Message-ID: References: <4zd3ncg5zm.fsf@fencepost.gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1296511812 21676 80.91.229.12 (31 Jan 2011 22:10:12 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 31 Jan 2011 22:10:12 +0000 (UTC) Cc: emacs-devel@gnu.org To: "'Giorgos Keramidas'" , "'Glenn Morris'" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 31 23:10:08 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Pk1wV-0006t5-V7 for ged-emacs-devel@m.gmane.org; Mon, 31 Jan 2011 23:10:08 +0100 Original-Received: from localhost ([127.0.0.1]:45812 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pk1wO-0000Pt-Mq for ged-emacs-devel@m.gmane.org; Mon, 31 Jan 2011 17:09:44 -0500 Original-Received: from [140.186.70.92] (port=41777 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pk1w4-00007w-Fm for emacs-devel@gnu.org; Mon, 31 Jan 2011 17:09:28 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pk1rE-00072D-K6 for emacs-devel@gnu.org; Mon, 31 Jan 2011 17:04:25 -0500 Original-Received: from rcsinet11.oracle.com ([148.87.113.123]:24093) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pk1rC-00071a-KR; Mon, 31 Jan 2011 17:04:22 -0500 Original-Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rcsinet11.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id p0VM4Gvc017039 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 31 Jan 2011 22:04:17 GMT Original-Received: from acsmt355.oracle.com (acsmt355.oracle.com [141.146.40.155]) by acsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id p0VM4Fdm018994; Mon, 31 Jan 2011 22:04:15 GMT Original-Received: from abhmt018.oracle.com by acsmt355.oracle.com with ESMTP id 968186491296511448; Mon, 31 Jan 2011 14:04:08 -0800 Original-Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 31 Jan 2011 14:04:08 -0800 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: AcvBiOmn+zkRf4x5Q/Kr73cCMmNL8wABOV3Q X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 X-Source-IP: acsinet15.oracle.com [141.146.126.227] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090204.4D4731E1.0188:SCFMA922111,ss=1,fgs=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 148.87.113.123 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:135359 Archived-At: > > You're saying: make the default font height be 1.4 times the default > > font height. The default font height must be absolute. > > http://debbugs.gnu.org/cgi/bugreport.cgi?bug=2659 > > Ah, I see now. So the underlying face must already have > *some* :height value, so this is not the right way to > specify the initial face-height. It might help if the doc either avoided the undefined term "underlying face" or explained what it means by that. Does it mean to refer to face-attribute inheritance? If so, it should say so; if not, it should say what is really meant by an "underlying" face for the face whose attribute you are setting. Can multiple faces underly a given face? How to find the underlying faces for a given face? Etc. The Elisp manual (node Face Attributes) does a pretty good job here in fact, but the relation to face inheritance is not so clear. A distinction is made in the `:inherit' entry of node Face Attributes, but without any explicit definitions. There should be a cross-ref to node Face Attributes from any other places (e.g. node Attribute Functions, `merge-face-attributes') where we mention underlying faces. The doc string for `set-face-attribute' explains nothing about "underlying face", however. It needs at least a pointer to the corresponding manual page to become comprehensible. FWIW, there are additional places in the docs where "underlying" is used with no real definition/explanation. It might seem shorter for the person writing the description to use such a term, but without any explanation it can take longer for a user to understand what is meant. Sometimes adding a cross reference might suffice to clear things up. If a sentence makes about the same amount of sense with and without the qualifier "underlying" it's a sign that it should probably just be removed. E.g., if in some context "the file system" is about as clear as "the underlying file system", then go with the former. Put differently, if "the file system" is not clear enough in some context then just adding "underlying" will not help: If it has any effect it will only be to confuse (why the qualifier? what does it mean here?). Emacs manual: "underlying text representation" (for images) "underlying system's text representation" (for international coding) "underlying details about charsets" (for charsets) "underlying VC" (for version control) "underlying method" (for EDE) "underlying shell" (for shell options) "underlying face" (for face resources) Elisp manual: "underlying OS" (for frame configs) "underlying OS" (for subprocesses) "underlying buffer text" (for keymaps) "underlying platform" (for eol conversion) "`underlying face'" (for face attributes) Doc strings: "underlying file system" (expand-file-name) "underlying face" (face-remapping-alist) "underlying face" (set-face-attribute) "underlying file system" (shell-quote-wildcard-pattern) "underyling version-control system (vc-rollback)